This project is archived and is in readonly mode.
3.0.6
Progress
% Complete
Tickets Left
Expected Mar 27th, 2011
Yehuda Katz (wycats)
13 open tickets
- 4554 render :text => proc { ... } regression open
- 4858 [PATCH] ActionMailer is html escaping plain text messages open
- 5247 [PATCH] assert_template wrong behavior for testing layout used to render template? open
- 4091 ActiveRecord::SessionStore allows blank session_id incomplete
- 5472 Potentially resolved… Callback API change breaks #run_callbacks open
- 3254 Merge Dispatcher and Middleware in Application object new
- 4113 Rails 3 - Windows Vista x64 - Error "different prefix:" - Two Hard Drives new
- 5006 ActiveSupport::BufferedLogger and us-ascii message on ruby 1.9.x open
- 4781 rjs function tests fail open
- 3927 Rails 3.0.0-pre - stylesheet_link_tag, javascript_include_tag cache fails when using File.atomic_write: Invalid cross-device link open
- 2872 sqlite3 adapter drops :decimal columns precision & scale when migration tries to alter them incomplete
- 3132 simple "rack test" fails incomplete
- 2379 [PATCH] Make path to tmp directory configurable new
Wednesday, March 23 2011
-
Andrew White commented at 5:50 PMOkay, sent a pull request to Josh. Once that's been applied and then the vendored regin in rack-mount is updated we can then look at bumping the rack-mount vers...
-
- State changed from open to resolved
(from [3a7c7dc73d6111e7c821a81d9c56024dd35769a5]) Fix test for prepend giving a false positive. [#5716 state:resolved]
Signed-off-by: José Valim jose.valim@gmai...
-
Javix commented at 3:36 PM
Yes, I came back to the original rails-3.0.5 version, downloaded the THREE file you posted before:
https://github.com/rails/rails/commit/7717fc375ee45d7cb1fa16... -
Santiago Pastorino commented at 3:08 PM
so you downloaded those files from 3-0-stable and still doesn't work?
Paste me the backtrace -
Javix commented at 2:52 PM
As I pointed before it is NOT a Rails application, so I have no Gemfile to define it. I'm just running a Ruby file (see attached before) :).
By the the way with... -
Santiago Pastorino commented at 2:49 PM
I think the best way for you is to point your Gemfile to rails 3-0-stable on edge ...
so change this ...
gem 'rails', '3.0.5'
with this ...
gem 'rails', :git =>...
-
Javix commented at 2:42 PM
Just these 3 commits and no need to take the modified ?
activemodel/lib/active_model/attribute_methods.rb activerecord/lib/active_record/attribute_methods/rea...
-
-
-
Javix commented at 9:51 AM
Still no luck. I tried the 3 files you committed (see above) and got the below error:
C:/Ruby192/lib/ruby/gems/1.9.1/gems/activerecord-3.0.5/lib/active_record/... -
Javix commented at 8:48 AM
I saw your 3 commits at master:
- activemodel/lib/active_model/attribute_methods.rb - activerecord/lib/active_record/attribute_methods/read.rb - activerecord/li... -
-
Andrew White commented at 12:12 PM
Okay, I've sent a pull request to Josh: https://github.com/josh/rack-mount/pull/15
Since the :format parameter is Rails-specific we need to specify the non-gree...
-
Prem Sichanugrist (sikachu) commented at 11:30 AMBy the way, I'm backing of on pulling those two Aaron's patch back, as I don't think user would expect that on a stable branch. I don't think I want to break so...
-
Prem Sichanugrist (sikachu) commented at 11:04 AM
If it's a simple fix, then I'm totally agree with you. Are you going to fix that in Rack::Mount for me, or do you want me to send pull request in?
Anyhow, here'...
-
Andrew White commented at 10:33 AM
There's a simple fix required in Rack::Mount - it ignores custom conditions on glob params. Once that is fixed we can use the regexp above to detect whether the...
-
- State changed from resolved to verified
@Andrew White: but then the RegExp actually has to be fixed in Rack::Mount, right?
Tuesday, March 22 2011
-
Santiago Pastorino commented at 11:25 PM
Javix should be working now, can you test it with Oracle though?.
Let me know.
-
- State changed from verified to resolved
(from [2ef6270f8fbbefba8d4f10504497e198d8e7deea]) Merge branch 'master' into fuuu
- master: Do not show optional (.:format) block for wildcard route [#6605 state...
-
- State changed from resolved to verified
A couple of things to note - firstly the glob param may have other elements before it and secondly you may have multiple glob params in a path. You'd be better ...
-
- State changed from verified to resolved
(from [2ddfdba9a0dab7d8499c3ad0d13583bddbac4f69]) Do not show optional (.:format) block for wildcard route [#6605 state:resolved]
This will make the output of
r... -
Prem Sichanugrist (sikachu) commented at 3:36 PM
This is a patch for
master.I'm still working on the patch for
3-0-stable, as my patch is currently rely on these two commits: https://github.com/rails/rails/co... -
Prem Sichanugrist (sikachu) created the ticket at 3:19 PM
Currently in Rails, when you're adding a wildcard route and run
rake routes, you'll usually see an entry like thisroutes.rb
match '/*path', :to => 'pages#show...
Monday, March 21 2011
-
- State changed from new to committed
- Milestone set to 3.0.6
- Importance changed from to Low
Merged. Thanks!
-
Javix commented at 12:19 PM
and here are columns and their data types:
ATT1 VARCHAR2(4000), ATT10 VARCHAR2(4000), ATT11 ... -
Javix commented at 8:55 AM
Hi, Santiago!
I've just testes the patch you posted above with 'attribute_methods.rb' from master. Still get the error:
C:/Ruby192/lib/ruby/gems/1.9.1/gems/act...
Sunday, March 20 2011
-
Santiago Pastorino commented at 4:47 AM
Javix anyways if you can specify exactly how was lcssupplier defined ... would be great.
At least tell me the column name and datatype which is causing the issu...
Saturday, March 19 2011
-
Javix commented at 8:33 PM
Hi Santiago, I'll be able to test the patch next Monday only. I have no Oracle on my Ubuntu OS.
Second point, as for the DB schema, I don't have it at all. It's... -
Santiago Pastorino commented at 2:11 PM
Can you show me the schema? I want to know how are you defining lcssupplier ...
Friday, March 18 2011
-
Santiago Pastorino commented at 4:54 PM
Javix can you try this patch file https://gist.github.com/876407 ?
Tell me what happens I'm making a test case for Oracle to ensure that this doesn't happen aga... -
Santiago Pastorino commented at 1:18 PM
Javix ok we will be testing with Oracle today to see what's going on.
Thanks for reporting the issue. -
Javix commented at 1:12 PM
Right, I used oracle enhanced adapter: activerecord-oracle_enhanced-adapter (1.3.2), ruby 1.9.2p180 (2011-02-18) [i386-mingw32], rails-3.0.5, all that on Window...
-
Javix commented at 1:09 PM
I took the 'attribute_methods.rb' file from https://github.com/rails/rails/blob/master/activemodel/lib/active_m....
Run the same Ruby script and got another er...
-
- State changed from committed to open
Nevermind I see where the new problem is, I need an Oracle db to test that.
OK I will try to fix this today.
-
-
Javix commented at 8:09 AM
-
Javix commented at 8:09 AM
Hi Santiago !
Just checked it again(see the attached file I run) and got the below error:
C:/Ruby192/lib/ruby/gems/1.9.1/gems/activerecord-3.0.5/lib/active_rec... -
-
- State changed from open to committed
(from [691530a19d1b335b6e8bc9f4c20c96124625acbe]) Sync attribute_methods.rb with master code, tests added
[#6580 state:committed] https://github.com/rails/rail...
-
Santiago Pastorino commented at 12:28 AM
Javix thanks for your feedback, this will be fixed for 3.0.6, I'm going to push a fix soon.
-
- State changed from committed to open
- Milestone set to 3.0.6
- Assigned user set to Santiago Pastorino
Monday, March 14 2011
-
Jonathan Monahan commented at 4:00 PMFWIW, we had a similar problem on Rails 2.2.x and fixed it by monkey patching ActiveRecord::Base.inspect:
module ActiveRecord class Base def self.inspect...
Saturday, March 12 2011
-
Chris Oliver commented at 10:48 PM(from [015192560b7e81639430d7e46c410bf6a3cd9223]) Fixed a bug when empty? was called on a grouped Relation that wasn't loaded
[#5829 state:resolved]
Signed-off-...
-
- State changed from open to resolved
(from [3a22e744162ce4d29f228e76d3e3ff355c93b88f]) Fixed a bug when empty? was called on a grouped Relation that wasn't loaded
[#5829 state:resolved] https://gi...
-
- State changed from new to open
- Milestone set to 3.0.6
- Importance changed from to Low
Chris Oliver has created a pull request that can help to resolve this issue: https://github.com/rails/rails/pull/218
-
Andy commented at 5:34 PM
By the way, about the patches above and Evgeniy Dolzhenko's explanation. I don't doubt that fixes a real issue, but I don't think it explains Garrett's original...
-
Andy commented at 5:25 PM
The key part of the backtraces that I'm seeing is this (see https://github.com/ajh/show_tables/blob/master/README for a full backtrace):
/home/ajh/.rvm/gems/ru...
-
- State changed from open to duplicate
I've added a note on #5829 referencing Chris' pull request. Closing this out as a duplicate.
No messages in this milestone.