Activity (RSS)

Following on from [#276], here's another small patch that adds support for scp syntax urls:

[user@]host.xz:/path/to/repo.git/

This is helpful primarily becau...

Maybe I'm missing something, but I put this test in my branch:

def test_first_on_association_with_conditions

firm = Firm.new("name" => "A New Firm, Inc")

fi...

Just noticed that while you can do stuff like this:

Topic.first :conditions => { :foo => bar }

Trying the same type of thing across an association won't wor...

Entered wrong ticket number. Silly me.

(from [1b0654ea41d15552c19f767570d4f551d617e742]) Ensure script/plugin installs ssh/git plugins. [#277 state:resolved]

Signed-off-by: Pratik Naik

http://git...

A small addition to the ActionView::Helpers::PrototypeHelper for use in .rjs templates or render(:update) blocks. It simply sends window.location.reload(); to ...

Fixed in http://github.com/rails/rails/co...

You would have thought so. It still took me a good half am hour of staring at that line before I spotted the typo in disguise!!

There're no existing tests for this but this is an obvious fix. Good catch :)

I was having problems installing git based plugins over SSH, e.g.

ssh://[user@]host.xz/path/to/repo.git/

Bit of digging and I spotted a typo in railties/lib/...

Here's a patch for the issue - it includes tasks from frozen gems in exactly the same way they're included from plugins (e.g., /vendor/gems/*/**/tasks/**/*.rak...

On Postgres when calling find on a model with an :include that contains an association with the same name as it's key an exception is raised:

>> Project.find(...

+1.

(from [235d635708dd72bee0828457af5397c79750483a]) Ensure :select passed in options overrides the one from the scope. [#239 state:resolved]

Signed-off-by: Prat...

Okay I've modified the patch to check both the sql generated and whether attributes are/are not present in the attributes hash after doing a find.

Looks good.

Could you please change tests to check both :

1) Query fired ( as you've already done )

2) Assert result of a find. For example Developer.find(:...

Patch is missing tests.

Thanks.

(from [abb1bd2efa43b8efbb3faf4ccfb9246704a9044c]) Ensure AssociationCollection#count works with empty condition. [#271 state:resolved] [Jan De Poorter]

http:/...

(from [cf6299dbd73a8cb6d74265df03d01abe885e686a]) Add ActionMailer#reply_to. [#245 state:resolved]

Signed-off-by: Pratik Naik

http://github.com/rails/rails/...

This patch feels like a hack. You should just be using mocking/stubbing for such cases.

Thanks.

Not in favor of the patch really. You can always do what Jan said.

Thanks.

Updated the patch to fix a line of trailing whitespace.

Error messages from validates_format_of can't currently include the rejected value the way validates_inclusion_of and validates_exclusion_of can. This patch en...

Small correction:

def klass

@klass ||= (options[:class_name].constantize rescue nil) || active_record.send(:compute_type, class_name)

end

Make this change ...

A simple workaround to fix this:

..../activerecord-2.0.2/lib/active_record/reflection.rb:124

def klass

@klass ||= active_record.send(:compute_type, class_na...

If I have two nested models:

User::Candidate

Resource::Resume

and I have within my candidate model:

has_many :resumes, :class => "Resource::Resume"

Active...

There is an ongoing trend to package Rails plugins as gems. Features recently added to Rails (config.gem, rake gems:*) make this only easier.

Before we forget...

When using conditions from a variable, it can sometimes be an empty hash (at least in my projects). When using it with count on a ActiveRecord::Base:

User.cou...

I have a User and an Address model, where User has_one :address. When creating the Address mode, I am planning for a polymorphic association for another model ...

+1. Code, tests and docs look good to me. Patch applied well and I was able to use the reply_to functionality fine. Looking forward to not having to put it int...

Forget patch 1 of the series. I see an equivalent fix has already been committed here:

http://github.com/rails/rails/co...

Yet another patch. This one applies on top of the previous patch, although I can make a patch which instead applies on top of the current "master" if desired.

...

Ok, attaching another patch which fixes the other problem by adding the "ext" subdirectory inside the frozen gem for those gems which have it.

Ok, I believe I've fixed the first issue (exceptions thrown for uninstalled gems) with the patch that I'm going to attach now.

The problem was in the plugins ...

I've tried using the new config.gem feature in Rails 2.1.0_RC1 with a gem which is a "pure" C extension (all C, no Ruby); that is, inside the gem the code live...

See also ticket #268. I ran into one of the problems mentioned here (the bombing out on nil) and attached a patch that fixes it. But looks like the equivalent ...

After 2.1

(from [08763e606282f14fe98f4cf87a9f93d6836373cc]) Callbacks fire before notifying observers [#230 state:resolved]

Signed-off-by: Joshua Peek

http://github.c...

(from [c2fbcba16d2349285368c86b849db946dc0e7d57]) Ensure named_scope#empty? uses count query. [#262 state:resolved]

Signed-off-by: Pratik Naik

http://github...

Where would one put error_messages_for @article.feed? In feeds/_feed.html.erb or in articles/new.html.erb?