Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Sunday, April 20 2008
27 Ares logs response content not response size was created
  • Sean Geoghegan
    Sean Geoghegan created the ticket at 7:48 AM

    This is a super tiny patch that makes Ares log the response length not the response size. Logging the response content can raise errors if there are string su...
22 default_url_options is being ignored by named route optimisation was updated
3 AssetTagHelper should accept a slightly wider range of protocols was updated
  • josh
    • State changed from open to invalid
    by josh at 3:13 AM
  • Cheah Chu Yeow
    Cheah Chu Yeow commented at 2:33 AM

    Yup I agree that in this case there is no value using image_tag for inline images and in fact it just makes your page slower calling the image_tag helper when ...
Saturday, April 19 2008
13 Allow SEO friendly resources (ex. /my-resources) was updated
  • Doug Ramsay
    Doug Ramsay commented at 11:29 PM

    Joshua,

    I see what you're saying, and your solution does work. My thought was that this would offer a good alternative.

    For now, I plan to submit another pat...
  • jack dempsey (jackdempsey)
    jack dempsey (jackdempsey) commented at 10:55 PM

    Joshua,

    What exactly does "these kinds of changes" mean? If you have a resource named "foo-bar" wouldn't you expect the end result url to have a dash and not ...
  • josh
    • State changed from open to invalid
    by josh at 10:37 PM

    I'm really opposed to these kinds of changes. However, there should be a workaround if you really need to do it. 

    map.resources :valid_orders, :as => 'valid-or...
3 AssetTagHelper should accept a slightly wider range of protocols was updated
  • josh
    • Assigned user set to josh
    • State changed from new to open
    • Title changed from [PATCH] AssetTagHelper should accept a slightly wider range of protocols to AssetTagHelper should accept a slightly wider range of protocols
    by josh at 10:48 PM

    I'm not sure this is a good use of the image_tag method. image_tag tag is there to help you expand image paths and provide you with a "useful" alt tag.

    If you...
23 validates_uniqueness_of doesn't escape attributes was updated
  • Alex MacCaw
    Alex MacCaw commented at 10:38 PM

    I didn't know you could have spaces in column names - but if this is a problem then by all means just escape the column name.

  • Frederick Cheung
    Frederick Cheung commented at 7:54 PM

    Surely you only need to escape the column name though (and could not escaping the column break things if it was called something like "foo from"?)

  • Alex MacCaw
    Alex MacCaw commented at 4:48 PM

    That's right. I thought about escaping the column name, however I decided I'd follow the convention which seems to escape the table name, rather than the colum...
  • Rick
    Rick commented at 4:28 PM

    It's not actually quoting the column name though, is it? It looks like it's only disambiguating the column name by adding the table name to it.

  • Alex MacCaw
    Alex MacCaw commented at 9:41 AM

    Moved over from trac:

    http://dev.rubyonrails.org/ticke...

    It has 6 +1 already.

1 earlier change…
  • Alex MacCaw
    Alex MacCaw created the ticket at 9:39 AM

    Let's say I have a table with a column called 'key' (which is a SQL keyword). If I try and validate_uniqueness_of :key, the SQL query fails, since the attribut...
9 Adding records to a has_many collection does not work on initialization was updated
  • josh
    • State changed from open to hold
    by josh at 10:38 PM

    Please reopen this ticket once you've got some tests.

24 Prevent Dependencies.new_constants_in cleanup code masking real error when co... was updated
  • josh
    • Assigned user set to Jeremy Kemper
    • State changed from new to open
    by josh at 10:24 PM
  • Tom Ward
    Tom Ward created the ticket at 4:28 PM

    Previously, the code collecting watch_frames could fail leaving watch_frames

    defined but nil. The cleanup code checked watch_frames is defined, but not that ...
Add conditional options to caches_pag... was committed by Repository at 10:21 PM
25 Allow if option for caches_page was updated
  • Repository
    • State changed from open to resolved
    by Repository at 10:21 PM

    (from [14a40804a29a57ad05ca6bffbe1e5334089593a9]) Add conditional options to caches_page method [#25 state:resolved]

    Signed-off-by: Joshua Peek

    http://githu...
  • josh
    • Assigned user set to josh
    • State changed from new to open
    by josh at 9:27 PM
  • Paul Horsfall
    Paul Horsfall created the ticket at 7:35 PM

    This is a patch to allow an if option to be passed to caches_page, much as you can for session management. e.g. 

    caches_page :index, :if => Proc.new { |c| !c.r...
26 [PATCH] Fix for change_column :null => true in migrations was updated
  • Nate Wiger
    Nate Wiger commented at 9:02 PM

    +1 from ddollar

    Just copying a +1 from old Rails Trac

  • Nate Wiger
    Nate Wiger created the ticket at 9:02 PM

    Currently, using change_column with :null => true on a formerly :null => false column does not have the proper effect. This patch fixes this issue by explicitl...
10 Immediate flash values not accessible in tests was updated
  • Andreas Neuhaus
    Andreas Neuhaus commented at 8:37 PM

    Ouch. Even though all tests pass fine, it seems that the flash isn't swept in real applications with this patch.

  • Andreas Neuhaus
    Andreas Neuhaus commented at 8:30 PM

    I dug a little deeper into this problem and found out, that the flash is swept in process_cleanup. A view can display immediate flash values, because it access...
Remove unused ignore_missing_template... was committed by Repository at 7:42 PM
Introduce ActionView::TestCase for te... was committed by Repository at 7:08 PM
Move missing template logic to Action... was committed by Repository at 7:07 PM
Introduce ActionView::InlineTemplate ... was committed by Repository at 4:22 PM
16 Sqlite adapter doesn't handle quoted table names properly was updated
  • Murray Steele
    Murray Steele commented at 10:36 AM

    +1.

    Tested with sqlite3 (3.5.7 / 3.5.6)

22 default_url_options is being ignored by named route optimisation was created
21 db:structure:dump broken by 8a5a9dc was created
  • Kyle Hargraves
    Kyle Hargraves created the ticket at 6:16 AM

    Commit 8a5a9dc to active_record/connection_adapters/abstract/schema_statements.rb removed the method dump_schema_information, which is called in the db:structu...
Friday, April 18 2008
20 improve mailer generator and add tests was updated 1 earlier change…
  • Mislav
    Mislav created the ticket at 10:55 PM

    This is what mailer generator used to generate: 

    class Notifier < ActionMailer::Base
  def reset_password()
    @subject = "..."
    @from    = "..."
    #...
Add example for default_url_options[:... was committed by Repository at 11:20 PM
Merge branch 'master' of git@github.c... was committed by Repository at 11:15 PM
Cleanup generator tests by extracting... was committed by Repository at 11:15 PM
Changed mailer generator to not use i... was committed by Repository at 11:15 PM
Slight optimization to CallbackChain#... was committed by Repository at 8:45 PM
16 Sqlite adapter doesn't handle quoted table names properly was updated
  • Frederick Cheung
    • Title changed from Sqlite adapter does handle quoted table names properly to Sqlite adapter doesn't handle quoted table names properly
    by Frederick Cheung at 7:52 PM
10 Immediate flash values not accessible in tests was updated
  • josh
    • State changed from open to invalid
    by josh at 5:28 PM

    Flash nows aren't store in the session response. They are just pushed directly to the template. So the best way to test them would be with an "assert_select".

    ...
  • Andreas Neuhaus
    Andreas Neuhaus commented at 2:41 PM

    New patch with git metainfo

  • Andreas Neuhaus
    Andreas Neuhaus commented at 2:08 PM

    I modified the test to assert_equal flash.now, but it still doesn't seem to work (patch attached).

    I also created a new rails project with a controller action...
Refactor Dispatcher callbacks to remo... was committed by Repository at 3:02 PM
19 Resource routes with :path_name and :member was created
Tidy up ActiveSupport::Callbacks::Cal... was committed by Repository at 5:30 AM