This project is archived and is in readonly mode.
[PATCH] Date.advance modifies option hash
-
josh- State changed from new to incomplete
Seems like a tiny patch worth committing. Can you please whip up a diff and some tests?
-
jedediah- Assigned user set to josh
How do you feel about making this change across the whole API? As in, fixing every method that modifies it's options? There are quite a few that do it. I've fixed a good chunk of them already but I thought I'd check before I go any further in case I'm wasting my time.
-
josh
- Assigned user cleared.
-
John Pignata
- Tag changed from activesupport, bug to activesupport, bug, patch
- Assigned user set to josh
- Title changed from Date.advance modifies option hash to [PATCH] Date.advance modifies option hash
Here's a patch for 2-3-stable and master to close this minor issue.
-
Repository
- State changed from incomplete to resolved
(from [7316d029e60f5d531b35af9e66d233ea19e4f240]) Duplicating the options hash in Date#advance to prevent modification of the original [#1133 [PATCH] Date.advance modifies option hash state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com
http://github.com/rails/rails/commit/7316d029e60f5d531b35af9e66d233... -
Repository
(from [49c4a79e59622c74cc9bb1aad04435ab171baf7c]) Duplicating the options hash in Date#advance to prevent modification of the original [#1133 [PATCH] Date.advance modifies option hash state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com
http://github.com/rails/rails/commit/49c4a79e59622c74cc9bb1aad04435...
