This project is archived and is in readonly mode.
Make auto_link_urls accept commas in the querystring of URLs
Reported by Gareth Harper | October 1st, 2008 @ 11:41 AM | in 2.x
auto_link_urls currently accepts commas in the path of the URL part like the old vignette format ie
http://www.people.com/people/0,,...
However it does not currently accept commas in the querystring of a URL like the current google maps format ie
http://maps.google.co.uk/maps?f=...,-0.114691&sspn=0.007052,0.012767&ie=UTF8&ll=51.503373,-0.11939&spn=0.007052,0.012767&z=16&iwloc=A
I've created a patch and associated test which fixes this
Comments and changes to this ticket
-
Gareth Harper October 1st, 2008 @ 11:42 AM
LOL, well, you can see the failing URL in the google example
that should be
-
Gareth Harper October 2nd, 2008 @ 02:31 PM
- Title changed from Make auto_link_url accept commas in the querystring of URLs to Make auto_link_urls accept commas in the querystring of URLs
- Tag set to patch
-
Michael Koziarski November 14th, 2008 @ 03:28 PM
- State changed from new to duplicate
- Tag changed from patch to actionpack, helper, patch, tested
fixed by #1353
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 1353 auto_link helper fails to parse some URLs with brackets Here is a patch that completely refactors auto_link_urls,...