This project is archived and is in readonly mode.
rake rails:freeze:edge should place the git revision into a REVISION file
-
Pratik
- Assigned user set to josh
- Tag changed from 2.3, commit, edge, freeze, git, rails, railties, rake, revision to 2.3, commit, edge, freeze, git, patch, rails, railties, rake, revision
- State changed from new to incomplete
- Title changed from [PATCH] rake rails:freeze:edge should place the git revision into a REVISION file to rake rails:freeze:edge should place the git revision into a REVISION file
Agree with Matthew. But the current file name style is being used in railties/builtin/rails_info/rails/info.rb. So that needs changing too.
Assigning to Josh as he committed the original thingy.
-
josh
- Assigned user cleared.
-
Luke Chadwick
Added patch for 2-3-stable that includes both the patch above and the required change to 'railties/builtin/rails_info/rails/info.rb'
A patch for edge/3.x is on it's way.
-
Luke Chadwick
- Assigned user set to Ryan Bigg
No rails 3 patch. 'rake rails:freeze:edge' has been deprecated in favour of 'bundle install'
-
Ryan Bigg
- Milestone changed from 3.x to 2.3.6
Fix milestone as per Luke's comments.
Luke: Pratik mentions that it's being used in railties/builtin/rails_info/rails/info.rb. Is this still the case? Please advise.
-
Luke Chadwick
There is still code in both 2-3-stable and master to read the revision from 'railties/builtin/rails_info/rails/info.rb' and 'railties/lib/rails/info.rb' respectively.
As I mentioned, the ability to create the file has been removed in master/3.x.
Is reading the REVISION* file still something that needs to be supported for legacy reasons or should it be removed altogether in master?
-
Ryan Bigg
Given the circumstances with Bundler, I don't think it needs to be supported in the future release. Use the convention.
-
Luke Chadwick
Here is the patch that removes the checking master/3.x and added a deprecation warning.
-
Rizwan Reza
- Tag changed from 2.3, commit, edge, freeze, git, patch, rails, railties, rake, revision to 2.3, bugmash, commit, edge, freeze, git, patch, rails, railties, rake, revision
-
Rizwan Reza
- Milestone cleared.
- Tag changed from 2.3, bugmash, commit, edge, freeze, git, patch, rails, railties, rake, revision to 2.3, bugmash-review, commit, edge, freeze, git, patch, rails, railties, rake, revision
- State changed from incomplete to verified
This is looking good. Both patches apply cleanly. This last patch is for master. There is a patch for 2-3-stable above.
-
Repository
- State changed from verified to resolved
(from [5d979de1a95bb6688d13781a7a42e04acdb3b9cb]) when we run rake rails:freeze:edge update the value of the "REVISION" file rather than creating a new file "REVISION_ce706..." each time [#1694 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/5d979de1a95bb6688d13781a7a42e0... -
José Valim
- Milestone cleared.
- State changed from resolved to open
- Assigned user changed from Ryan Bigg to José Valim
Luke, is there a reason to keep the "freeze_edge_version" method in the patch for rails master? We cannot simply remove it?
-
Rizwan Reza
- Tag changed from 2.3, bugmash-review, commit, edge, freeze, git, patch, rails, railties, rake, revision to 2.3, commit, edge, freeze, git, patch, rails, railties, rake, revision
- State changed from open to resolved
José is right, we don't need this for master/Rails 3. Please comment if otherwise.
-
Rizwan Reza
- Tag changed from 2.3, commit, edge, freeze, git, patch, rails, railties, rake, revision to 2.3, bugmash-review, commit, edge, freeze, git, patch, rails, railties, rake, revision
Since we don't need it, let's just remove it. :)
-
Rizwan Reza
- State changed from resolved to verified
-
Rizwan Reza
Here's more removal. :)
-
Rizwan Reza
- Tag changed from 2.3, bugmash-review, commit, edge, freeze, git, patch, rails, railties, rake, revision to 2.3, commit, edge, freeze, git, patch, rails, railties, rake, revision
- State changed from verified to resolved
-
Jeff Kreeftmeijer
Automatic cleanup of spam.
