This project is archived and is in readonly mode.
TestSession and AbstractStore delete and update methods do not match in parameter count
-
Pratik
- Milestone cleared.
- Assigned user set to josh
-
gaffo
Should be fixed with attached patch. Also backfilled some tests on TestSession (didn't have any that I could find).
-
Amos King
backfilled tests, and fixed a bug. +2
-
yairgo
verified. +1
-
josh
- State changed from new to open
- Assigned user set to josh
-
Repository
- State changed from open to resolved
(from [f17c87665e36206bcae9c260cb25cd67bf9695e6]) Fixed deprecated methods on TestSession [#1801 state:resolved] http://github.com/rails/rails/co...
-
Amos King
Josh, why didn't you take the tests that gaffo had committed?
-
josh
I don't think we should add those other helper functions, for an example instead of clear_test_session, you could just use clear since its just a hash.
If you could please update the tests to apply cleanly I'll surely commit them.
-
gaffo
Re coded tests.
-
Repository
- State changed from open to resolved
(from [1b79683171eeb0f5eb07928aeace890dafe773fc]) Deprecation tests for f17c876 [#1801 state:resolved] Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
