This project is archived and is in readonly mode.

#1844 ✓resolved
Carlos Júnior (xjunior)

Render behaviour problem

Reported by Carlos Júnior (xjunior) | February 2nd, 2009 @ 01:21 PM

If I have this on controller:

  respond_to do |format|
    format.html { ... }

And I have some JS view, the view is being rendered with the layout, on 2.2.2 it defaults to :layout => false

Comments and changes to this ticket

  • Carlos Júnior (xjunior)

    Carlos Júnior (xjunior) February 2nd, 2009 @ 04:10 PM

    Hum! The only template I have is application.html.erb

  • DHH

    DHH February 2nd, 2009 @ 05:00 PM

    • Assigned user set to “josh”
    • Milestone cleared.
  • Mislav

    Mislav February 2nd, 2009 @ 05:31 PM

    • Assigned user cleared.

    I can confirm that a blank Rails app on edge wraps JS templates in application.html.erb layout -- definitely not what one would expect.

  • Mislav

    Mislav February 2nd, 2009 @ 05:33 PM

    • Assigned user set to “josh”

    Sorry for clearing the assignee, I had this comment form open from before DHH posted his update.

  • Carlos Júnior (xjunior)

    Carlos Júnior (xjunior) February 2nd, 2009 @ 07:13 PM

    @mislav, in my case it happened on a existing project updated to 2.3 (not that it makes that difference - I think)

  • Carlos Júnior (xjunior)
  • josh

    josh February 3rd, 2009 @ 11:22 PM

    • State changed from “new” to “open”

    A failing unit test would be really helpful. The actual fix even more :)

  • Adam McCrea

    Adam McCrea February 4th, 2009 @ 03:46 PM

    • Tag changed from 2.3, actionpack, actionview, view to 2.3, actionpack, actionview, patch, view

    Here is a failing test and fix.

  • Repository

    Repository February 5th, 2009 @ 09:46 PM

    • State changed from “open” to “resolved”

    (from [06182ea02e92afad579998aa80144588e8865ac3]) implicitly rendering a js response should not use the default layout [#1844 state:resolved]

    Signed-off-by: Joshua Peek

  • Matt Jones

    Matt Jones February 20th, 2009 @ 08:57 AM

    • State changed from “resolved” to “open”

    Just moved an app to 2.3, and spent quite some time figuring out why my Facebox popups (it's a JQuery plugin) had lost their title elements. Apparently this is why...

    I was using this in my application_controller.rb:

      layout proc { |c| c.request.xhr? ? 'popup' : 'application' }

    ..but it never gets called now.

    IMHO, this patch is not solving the problem - between it and the xhr? check on line 157, there's now NO way to default-render an HTML response with a layout from an AJAX request. 2.2.2's support, I recall, was a little more targeted...

    Specifically, the bug xjunior ran into was caused by this commit which removed the format-specific template searching code from default_layout (in layout.rb). The new code uses find_template, which automatically tries HTML templates if JS isn't available.

    Ideally, it would make sense to add an argument to find_template to turn off the html failover for templates. That would put the 2.2 behavior back, and not break my app... :)

    I'd be glad to submit a patch (we already have a test - yay), but I wanted to check if there was a reason that find_layout was declared with *formats, while find_template just takes a single format.

  • josh

    josh February 20th, 2009 @ 04:55 PM

    Matt Jones, patch would be great :)

    find_layout has really funky behaviors and since it wants to look though all available templates to decide if a layout should be used. I think its kind of inconsistent, but I didn't want to make any changes to its behavior.

  • josh

    josh February 20th, 2009 @ 08:25 PM

    Matt, #1974 may be related.

  • josh

    josh February 22nd, 2009 @ 04:41 PM

    • State changed from “open” to “resolved”

    Considered resolved for now. Please open a new ticket for any related issues or side effects.

  • Repository

    Repository April 13th, 2009 @ 11:58 PM

    (from [906aebceedb95d8caa6db6314bc90f605bdfaf2b]) Bring abstract_controller up to date with rails/master

    Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0:

    2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent

    06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically

    893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor;

    the changes here are very implementation specific and cannot be
    cleanly applied. The following commits are implicated:

    0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line

    commit, we will reimplement this change.

    8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature

    to the reimplemented ActionController::Base.

    87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded

    each other. Basically none of them apply cleanly, and the underlying
    issue needs to be revisited. After discussing the underlying problem
    with Koz, we will defer these fixes for further discussion.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>


Referenced by