Strange pluralize and routing

Still a problem in RC2, though the routes have changed a bit:

Phoenix ~/scratch/depot  $ rake routes
(in /Users/mike/scratch/depot)
     taxes GET    /taxes(.:format)                   {:action=>"index", :controller=>"taxes"}
           POST   /taxes(.:format)                   {:action=>"create", :controller=>"taxes"}
 new_taxis GET    /taxes/new(.:format)               {:action=>"new", :controller=>"taxes"}
edit_taxis GET    /taxes/:id/edit(.:format)          {:action=>"edit", :controller=>"taxes"}
     taxis GET    /taxes/:id(.:format)               {:action=>"show", :controller=>"taxes"}
           PUT    /taxes/:id(.:format)               {:action=>"update", :controller=>"taxes"}
           DELETE /taxes/:id(.:format)               {:action=>"destroy", :controller=>"taxes"}
                  /:controller/:action/:id           
                  /:controller/:action/:id(.:format) 

The underlying issue is:

"tax".pluralize.singularize => "taxis"

The generator uses the original singular name fed in when building views and controllers. But the routing code initializes the singular name by singularizing the name in the map.resources call. Hence the mismatch.

There is even simple decision - use another name. But at first I need to know that will have troubles with current choice.

Rails already show a note on using singularized name $ ./script/generate scaffold prices test:string

 warning  Plural version of the model detected, using singularized versi

on. Override with --force-plural.

It is few lines in /lib/rails_generator/generators/components/scaffold/scaffold_generator.rb

def initialize(runtime_args, runtime_options = {})

super

if @name == @name.pluralize && !options[:force_plural]
  logger.warning "Plural version of the model detected, using singularized version.  Override with --force-plural."
  @name = @name.singularize
end

Maybe add note too?

For example

if @name != @name.pluralize.singularize
  logger.warning "Attention you will get troubles this such name. Get another please."
end

Or even

if @name != @name.pluralize.singularize
  logger.warning "\033[01;31mAttention you will get troubles this such name. Get another please.\033[00m"
end

I've attached the diff to generators file.

I just hit this too. In addition to the warning, I'd suggest adding "tax" to the list of irregular inflections.

I can duplicate this on 2.3.5. Rishav, how did you test this?

Here's a patch to fix this.

So what about #2399 Incorrect inflectors for 'business' or '*ness' and "Rails has a longstanding policy of not taking further inflector patches. Use an initializer in your application instead"?

Santiago, why does inflection3 comment out a line? Also, could you please provide tests with your patches? Thanks.

Yes you're right Ryan i was trying things and forgot to uncomment this line also i was a bit lazy and did things wrong, ;).
Uploading again.