[PATCH] Ability to set SSL options on ActiveResource connections

Updating patch with latest as of this moment.

+1 for the feature

could not get this to apply cleanly to 2-3-stable or master

I'm not sure this belongs in 2.x, though. Maybe edge? I wonder too if we could put all this configuration in a module - lots of great and usable configuration, though

+1 for feature, definitely missing -1 on patch, "Patch does not have a valid e-mail address."

Updated patch.

Agree that this isn't 2.x. I'm not sure how it got that tag. If I did it, sorry about that.

Updated patch again to merge cleanly with changes from a0caad5255ed120192755fce10960a38b53c056d

-1

The idea is good but the patch does not apply to edge Rails.

can you explain? git apply ares_ssl_options.diff works fine for me in master.

Am I doing something wrong in making the patch?

+1 verified

patch applies on master with warnings:

Applying: Add ability to set SSL options on ARes connections.
/Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:27: trailing whitespace.
  # 
/Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:38: trailing whitespace.
  #  
/Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:54: trailing whitespace.
      # * <tt>:verify_depth</tt> - The maximum depth for the certificate chain verification.  
/Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:55: trailing whitespace.
      # * <tt>:cert_store</tt> - OpenSSL::X509::Store to verify peer certificate.  
/Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:61: trailing whitespace.
      
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

(from [3e0951632c52018eefb86d9e0bfe77383f9622fb]) Add ability to set SSL options on ARes connections.

[#2370 [PATCH] Ability to set SSL options on ActiveResource connections state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/3e0951632c52018eefb86d9e0bfe77...