Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

fix typo in stale session check

#2404

--- vendor/rails/actionpack/lib/action_controller/session/abstract_store.rb.org 2009-04-02 17:08:06.000000000 -0600 +++ vendor/rails/actionpack/lib/action_controller/session/abstract_store.rb 2009-04-02 17:07:23.000000000 -0600 @@ -74,7 +74,7 @@

             # Note that the regexp does not allow $1 to end with a ':'
             $1.constantize
           rescue LoadError, NameError => const_error

  •          raise ActionController::SessionRestoreError, "Session contains objects whose class definition isn\\'t available.\nRemember to require the classes for all objects kept in the session.\n(Original exception: \#{const_error.message} [\#{const_error.class}])\n"
    
    
  •          raise ActionController::SessionRestoreError, "Session contains objects whose class definition isn\\'t available.\nRemember to require the classes for all objects kept in the session.\n(Original exception: #{const_error.message} [#{const_error.class}])\n"
           end
    
           retry
    
    

Reported by ara.t.howard · April 3rd, 2009 @ 12:10 AM

State: resolved
Milestone: 2.x
Assigned to: josh josh
Importance: none

Activity

  1. ara.t.howard
    ara.t.howard
    --- vendor/rails/actionpack/lib/action_controller/session/abstract_store.rb.org 2009-04-02 17:08:06.000000000 -0600
    +++ vendor/rails/actionpack/lib/action_controller/session/abstract_store.rb 2009-04-02 17:07:23.000000000 -0600
    @@ -74,7 +74,7 @@
                     # Note that the regexp does not allow $1 to end with a ':'
                     $1.constantize
                   rescue LoadError, NameError => const_error
    -                raise ActionController::SessionRestoreError, "Session contains objects whose class definition isn\\'t available.\nRemember to require the classes for all objects kept in the session.\n(Original exception: \#{const_error.message} [\#{const_error.class}])\n"
    +                raise ActionController::SessionRestoreError, "Session contains objects whose class definition isn\\'t available.\nRemember to require the classes for all objects kept in the session.\n(Original exception: #{const_error.message} [#{const_error.class}])\n"
                   end
     
                   retry
    
    

    April 3rd, 2009 @ 12:10 AM

  2. ara.t.howard
    ara.t.howard
    • Assigned user set to Eloy Duran

    no tests on this one ;-)

    April 3rd, 2009 @ 12:11 AM

  3. yairgo
    yairgo

    I think you should test it against www.m-w.com

    April 3rd, 2009 @ 12:40 AM

  4. Eloy Duran
    Eloy Duran
    • Assigned user changed from Eloy Duran to josh

    @Ara & Joshua: I have an assertion method which could be used to test such functionality in nested_attributes_test.rb. Maybe it's time to make it globally available?

    http://github.com/rails/rails/bl...

    April 3rd, 2009 @ 08:30 AM

  5. ara.t.howard
    ara.t.howard

    i dunno - testing exceptions is pretty brittle as a rule. making the message less dynamic and/or having rails get less in the way would be my preference - it's turtles all the way down. ;-)

    April 3rd, 2009 @ 03:45 PM

  6. Repository
    Repository
    • State changed from new to resolved

    (from [82bc768dad761df466e38ee9f1501aef766878c3]) Fix typo in stale session check [#2404 fix typo in stale session check state:resolved] http://github.com/rails/rails/co...

    April 26th, 2009 @ 05:38 PM