This project is archived and is in readonly mode.
Console/log output for malformed XML requests is not very helpful
Hey guys,
First time patcher here, so go easy on me. I'm writing a REST service in Rails and a client in Flex. I knew my Flex app was sending malformed data but I had no way of inspecting it. The Rails log output really wasn't very helpful:
/!\ FAILSAFE /!\ Fri Apr 10 19:44:12 -0700 2009
Status: 500 Internal Server Error
You have a nil object when you didn't expect it!
The error occurred while evaluating nil.name
So my patch simply echo's the actual raw request and provides much more information:
It seems there was an error parsing the request.
The raw request is provided below:
some-malformed-XML-string-here
/!\ FAILSAFE /!\ Fri Apr 10 19:44:12 -0700 2009
Status: 500 Internal Server Error
You have a nil object when you didn't expect it!
The error occurred while evaluating nil.name
My patch uses puts (is that okay?)
-
show_malformed_XML_requests.diff
1.32 KB
-
CancelProfileIsBroken- Tag changed from debug, feature, patch, request, xml to bugmash, debug, feature, patch, request, xml
-
Gabe da Silveira
+1 on fixing this issue. I've been annoyed by this for quite some time. Using puts is not the right approach, but we ought to be able to do something about it...
-
Elad Meidar+1 Verified... /!\ so annoying /!\
Patch applies and all tests pass on 2-3-stable (it's more of an output formatting thing... needs tests?)
Attached a patch for master.
-
Rizwan Reza+1 On the feature. But I would suggest adding some tests.
-
Jeremy Kemper- Assigned user set to Jeremy Kemper
- State changed from new to incomplete
- Milestone changed from 2.x to 2.3.4
Needs tests.
-
John Pignata
Here's my shot at it.
1) Instead of using puts, I've used the Rails.logger or $stderr in the absence of that.
2) I've added tests to the json and xml parser tests which capture $stderr and ensure that the log entry was madeLet me know your feedback.
-
Rizwan Reza
Verified. The patch by John applies cleanly on master. It doesn't work in 2-3-stable.
-
John Pignata
Thanks, Rizwan. Here's a patch that applies to 2-3-stable.
-
Elad Meidar
2-3-stable patch applies cleanly, tests pass. Tested manually as well.
-
Repository
- State changed from incomplete to committed
(from [1cf32ad35a32cc1259a5aebfb894f53610ffac8e]) Adding a call to logger from params_parser to give detailed debug information when invalid xml or json is posted
[#2481 Console/log output for malformed XML requests is not very helpful state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/1cf32ad35a32cc1259a5aebfb894f5... -
Repository
(from [679128da58636f3ec96e24fcb7daac24666b2dad]) Adding a call to logger from params_parser to give detailed debug information when invalid xml or json is posted
[#2481 Console/log output for malformed XML requests is not very helpful state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/679128da58636f3ec96e24fcb7daac...