This project is archived and is in readonly mode.
with_scope should accept and use order option
This patch adds support for order and nested orders when using with_scope.
Tests included, all tests passing on MySQL, Sqlite3 and Postgresql.
This will probably also close the following ticket:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...
-
duncanbeevers+1
I think this fits best with people's expectations of how scopes should compose.
-
-
Dan Pickett- Tag changed from activerecord, patch, with_scope to activerecord, bugmash, patch, with_scope
-
Jeff Kreeftmeijer+1
Applies cleanly to master and tests pass. Nice addition! :)
-
Anil WadghuleI am trying to apply this patch with 'git am < patch.diff'. Patch is not getting applied for me http://pastie.org/961761. Am I missing something here?
-
Enrico BiancoI'm having the same trouble applying this patch. The places where it fails don't even seem to be functional changes. Trying to edit the patch...
-
Craig Krigsman
I'm unable to apply this patch either.
Base.rb 401 is a comment apply error.
.rb wrong line apply location.Working on revised diff.
Error output.
error: patch failed: activerecord/lib/active_record/base.rb:401
error: activerecord/lib/active_record/base.rb: patch does not apply
error: patch failed: activerecord/test/cases/method_scoping_test.rb:657
error: activerecord/test/cases/method_scoping_test.rb: patch does not apply -
Enrico Bianco
Seems the with_scope method has changed considerably since this patch. Possibly some logic moved into arel that used to be in ActiveRecord::Base?
-
SenthilI also got a very similar set of error while applying the patch http://gist.github.com/402327
-
Rizwan Reza- Tag changed from activerecord, bugmash, patch, with_scope to activerecord, patch, with_scope
- State changed from new to invalid
I am closing it. We can reopen if the issue still exists.
-
Craig Krigsman
- Tag changed from activerecord, patch, with_scope to activerecord, bugmash, patch, with_scope
-1 I would suggest this patch is no longer relevant to rails 3 since with_scope has been removed. http://m.onkey.org/2010/1/22/active-record-query-interface
-
