Rails Ruby on Rails

Comments and changes to this ticket

• 

  Yehuda Katz (wycats) July 2nd, 2009 @ 08:16 PM

  • State changed from “new” to “open”

• You flagged this item as spam.
  

  Bas van Klinkenberg August 1st, 2009 @ 01:40 AM

  • Title changed from “ActiveSupport::JSON.decode explodes in certain circumstances” to “[PATCH] ActiveSupport::JSON.decode explodes in certain circumstances”

  Here is a patch for this bug. I also believe this solves bug #2273.

  The cause of the bug is that between the moment when the position of the quotes around dates are tracked, and the moment those quotes are removed, the output string has changed size due to removing backslashes and/or decoding unicode sequences. Due to this wrong characters in the string are overwritten, causing Yaml to fail consequently, which causes a ParseError exception.

  This patch moves the code that replaces the quotes above the code that handles the backslashes and unicode sequences, before the string size changes.

  • fix_active_support_json_decode_yaml_dates_and_escaped_data.diff 4 KB
• 

  CancelProfileIsBroken August 8th, 2009 @ 01:01 PM

  • Tag changed from “2.3.2, activesupport, json” to “2.3.2, activesupport, bugmash, json”

• You flagged this item as spam.
  

  Nikolay Petrachkov August 8th, 2009 @ 01:18 PM

  • Assigned user set to “Pratik”

  Patch is verified for above code.

  Before:

  ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}')
  IndexError: index 38 out of string
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `[]='
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml'
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `each'
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml'
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:16:in `decode'
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `__send__'
      from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `decode'
      from (irb):1
  
  

  After patch:

  ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}')
  => {"d"=>Thu, 24 Jun 2004, "r"=>"http://foo"}
  

• 

  Rizwan Reza August 8th, 2009 @ 04:25 PM

  verified

  +1 This patch works perfectly. All tests pass.

• 

  Repository August 8th, 2009 @ 04:45 PM

  • State changed from “open” to “resolved”

  (from [0fbeaa98e4e60ca0949be298dae8545807407e1d]) Fixed a bug in JSON decoding with Yaml backend, where a combination of dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [#2831 state:resolved]

  Signed-off-by: Yehuda Katz wycats@gmail.com
  http://github.com/rails/rails/commit/0fbeaa98e4e60ca0949be298dae854...

• 

  CancelProfileIsBroken August 8th, 2009 @ 11:07 PM

  • Assigned user cleared.
  • Tag changed from “2.3.2, activesupport, bugmash, json” to “2.3.2, activesupport, json”
  • Milestone cleared.

• You flagged this item as spam.
  

  Nathan Beyer February 12th, 2010 @ 10:12 PM

  This issue is present in the 2.3.5 release. It looks like the patch was only applied to the 2.3.2 branch and didn't make it beyond that.

  Should a new bug be opened?

• You flagged this item as spam.
  

  gregpyp March 14th, 2010 @ 08:02 PM

  this bug is in the 2.3.5 too

• You flagged this item as spam.
  

  Nathan Beyer March 15th, 2010 @ 12:08 AM

  I created a new ticket with the patch ported to the 2-3-stable branch - https://rails.lighthouseapp.com/projects/8994/tickets/4102-ticket-2... .

• 

  Repository March 15th, 2010 @ 04:51 AM

  (from [b99914cc3e58e6444f66006cd4b9b4fa7368afe2]) Fixed a bug in JSON decoding with Yaml backend, where a combination of dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception.

  [#2831]

  Signed-off-by: Yehuda Katz wycats@gmail.com
  Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
  http://github.com/rails/rails/commit/b99914cc3e58e6444f66006cd4b9b4...

• You flagged this item as spam.
  

  ssupreme11 May 10th, 2011 @ 10:37 PM

  • Importance changed from “” to “”

  Its my first time to visit this site and as I was exploring I cant believe that this site was made up of a very informative articles that you should try to have compliment with so as what I am doing now I really love to look forward with more interesting information on this site. Dissertation Writing
  .