Deprecation warning for assert_redirected_to doesn't tell you where the offending code is

I have found this deprecation notice not to be reproducible. I found where it should be displayed, but have no idea what arguments to pass to make it happen.

Additionally, there does not seem to be a test for this deprecation in test/controllers/action_pack_assertions_test.rb

I take that back... verified:

Controller:

class MonkeysController < ApplicationController
  def index

redirect_to :controller => 'monkeys', :action => :show

  end



  def show



  end
end

Test:
@@@ruby class MonkeysControllerTest < ActionController::TestCase
test "assert_redirected_to" do

get :index
assert_redirected_to :action => :show

end end

And the output...

Josh is working on changing the output to include file and line number.

So, I've attached a patch that tries to use backtrace_cleaner for Deprecation. It works for the example case, but there's a few tests it seems to break, when it enters the cleaning process.

I opened #3015 use backtrace_cleaners when using Deprecation#warn as a more general case of this issue, and included a better patch.

I'm a little confused why you'd go and apply super-specific fix for this, ie assert_redirected_to, when there's a fix for a more general problem of Deprecation.warn reporting the wrong line.

I mean, I guess it's technically fixed for this particular reporting, but why make it brittle to what's calling it, and also having it remain for everything else using Deprecation.warn?

Because it's quick and easy and your better, more general fix was not
available yet!