This project is archived and is in readonly mode.

#2992 ✓resolved
Nobuhiro IMAI

[PATCH] visibility of fixture accssor methods

Reported by Nobuhiro IMAI | August 4th, 2009 @ 07:16 AM | in 3.0.2

Hello,

this is similar to #1708, but including another problem,
so I attached the same patch again. If there are the ways to
tell of updating the ticket that was marked as "incomplete" or
"invalid", please let met know.

Well, the teardown method is invoked even when the test method
comes from outside of the test script.

$ cat test/unit/test_result_test.rb 
require 'test_helper'

class TestResultTest < ActiveSupport::TestCase
  def teardown
    p @method_name
  end
end
$ ruby -Itest test/unit/test_result_test.rb -v
Loaded suite test/unit/test_result_test
Started
test_results(ActionController::IntegrationTest): .
test_results(ActionController::TestCase): .
test_results(ActionMailer::TestCase): .
test_results(ActionView::TestCase): .
test_results(ActiveRecord::TestCase): .
test_results(ActiveSupport::TestCase): .
test_results(TestResultTest): "test_results"
.

Finished in 0.233754 seconds.

7 tests, 0 assertions, 0 failures, 0 errors

Actually, I'm very annoyed the following case:

require 'test_helper'

class TestResultTest < ActiveSupport::TestCase
  def setup
    File.unlink(logfile)
  rescue Errno::ENOENT
  end

  def teardown
    assert_equal 1, File.unlink(logfile)
  end

  def logfile
    @logfile ||= Rails.root + "tmp/logfile"
  end

  test "create log 1" do
    File.open(logfile, "w"){|f| f.puts("log 1")}
  end

  test "create log 2" do
    File.open(logfile, "w"){|f| f.puts("log 2")}
  end
end

the result of above test is:

$ ruby -Itest test/unit/test_result_test.rb -v
Loaded suite test/unit/test_result_test
Started
test_results(ActionController::IntegrationTest): .
test_results(ActionController::TestCase): .
test_results(ActionMailer::TestCase): .
test_results(ActionView::TestCase): .
test_results(ActiveRecord::TestCase): .
test_results(ActiveSupport::TestCase): .
test_create_log_1(TestResultTest): .
test_create_log_2(TestResultTest): .
test_results(TestResultTest): E

Finished in 0.220522 seconds.

  1) Error:
test_results(TestResultTest):
Errno::ENOENT: No such file or directory - /tmp/233/tmp/logfile
    test/unit/test_result_test.rb:10:in `unlink'
    test/unit/test_result_test.rb:10:in `teardown'

9 tests, 2 assertions, 0 failures, 1 errors

Hmm, I don't know about the test_results method,
at least in my test/unit/test_result_test.rb.

After patching,

$ ruby -Itest test/unit/test_result_test.rb -v
Loaded suite test/unit/test_result_test
Started
test_create_log_1(TestResultTest): .
test_create_log_2(TestResultTest): .

Finished in 0.202083 seconds.

2 tests, 2 assertions, 0 failures, 0 errors

the result is quite simple and this is what I want :-).

Thanks,

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages