#3130 [PATCH] add strip_attributes support to ActiveModel and Active Record - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3130 ✓invalid

[PATCH] add strip_attributes support to ActiveModel and Active Record

Reported by Josh Sharpe | September 1st, 2009 @ 03:22 PM

Added support for ActiveModel#strip_attributes and ActiveRecord::Base.strip_attributes!

ActiveModel#strip_attributes removes leading and trailing
white spaces from all applicable attributes.

ActiveRecord::Base.strip_attributes! adds a before_validation
filter to your class which calls ActiveModel#strip_attributes.

Both support :only and :except as options.

This is useful for cleaning up form-inputted attributes.

This patch has been rebased for master.

strip_attributes.patch 7.5 KB

Comments and changes to this ticket

CancelProfileIsBroken September 25th, 2009 @ 12:36 PM
- Tag changed from “3.0, activemodel, activerecord, strip_attribtutes” to “3.0, activemodel, activerecord, bugmash, strip_attribtutes”
You flagged this item as spam.
Blue Box Jesse September 27th, 2009 @ 01:16 AM
BugMash: +1

Applies to master cleanly. Do not see any related errors as a result of the patch.

Good idea / useful tool.
You flagged this item as spam.
sr.iniv.t September 27th, 2009 @ 07:57 AM
+1 verified.

Great idea - i have run into situations where we needed this kind of behavior would have been helpful. The patch applies without any problems and all tests pass.
CancelProfileIsBroken September 27th, 2009 @ 11:57 AM
- Tag changed from “3.0, activemodel, activerecord, bugmash, strip_attribtutes” to “3.0, activemodel, activerecord, bugmash-review, strip_attribtutes”
Rizwan Reza January 18th, 2010 @ 02:06 PM
- Tag changed from “3.0, activemodel, activerecord, bugmash-review, strip_attribtutes” to “3.0, activemodel, activerecord, bugmash, strip_attribtutes”
The patch doesn't apply to master anymore.
Prem Sichanugrist (sikachu) January 20th, 2010 @ 06:43 AM
I've modify the patch to be applied on master
- strip_attributes-20100120.patch 7.2 KB
Prem Sichanugrist (sikachu) January 20th, 2010 @ 06:43 AM
- Tag changed from “3.0, activemodel, activerecord, bugmash, strip_attribtutes” to “3.0, activemodel, activerecord, bugmash, bugmash-review, review, strip_attribtutes”
Prem Sichanugrist (sikachu) January 20th, 2010 @ 09:23 AM
@Josh Sharpe

After I have discuss your addition in #rails-contrib, I can't really find a good use case for this method. So, I think this feature would be nice to be made as a plugin instead. If there're enough user using it, then it can be merged into core later.

Thank you :)
Yehuda Katz (wycats) January 20th, 2010 @ 09:26 AM
- State changed from “new” to “invalid”
Rizwan Reza May 15th, 2010 @ 06:45 PM
- Tag changed from “3.0, activemodel, activerecord, bugmash, bugmash-review, review, strip_attribtutes” to “3.0, activemodel, activerecord, bugmash, review, strip_attribtutes”
[bulk edit]