This project is archived and is in readonly mode.
[PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ?
-
-
John Pignata
- Tag changed from 3, activesupport, memoization to activesupport, memoization
-
John Pignata
- Tag changed from activesupport, memoization to activesupport, memoization, patch
- Title changed from ActiveSupport::Memoizable - flush_cache fails for methods ending in ? to [PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ?
-
CancelProfileIsBroken
- Tag changed from activesupport, memoization, patch to activesupport, bugmash, memoization, patch
-
Elad Meidar
- Tag changed from activesupport, bugmash, memoization, patch to activesupport, bugmash, bugmash-review, memoization, patch
+1 verified on master and 2-3-stable, patch applies cleanly.
As discussed on #railbridge some further tests for methods that end with ! as well could be nice, although not mandatory since ! is not a reserved regexp character.
-
hsume2 (Henry)+1 patched applied cleanly on master and 2-3-stable
-
sr.iniv.t
+1 verified.
The patch applies cleanly on master and 2-3-stable and all tests pass.
-
Kieran P+1 verified. Though perhaps a Regexp.escape might be more appropriate?
-
CancelProfileIsBroken
- Tag changed from activesupport, bugmash, bugmash-review, memoization, patch to activesupport, bugmash-review, memoization, patch
-
John Pignata
Kieran - The reason I couldn't use Regexp.escape is that it causes tests for the unmemoize_all method to fail as it passes .* to flush_cache.
-
Repository
- State changed from new to committed
(from [d48ebeade2d907573e3fb086495b57b10115066c]) Escaping symbol passed into Memoizable's flush_cache for query methods to allow them to be cleared
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3138 state:committed] http://github.com/rails/rails/commit/d48ebeade2d907573e3fb086495b57...
-
Rizwan Reza- Tag changed from activesupport, bugmash-review, memoization, patch to activesupport, memoization, patch
