This project is archived and is in readonly mode.
Tiny refactor of FormTagHelper#extra_tags_for_form
#3379
Tiny refactor of FormTagHelper#extra_tags_for_form
- removes a dead comment justifying an impossible case
- pulls out generation of the method/token tags so we can see them
- switches negative condition in token_tag for readability
Backstory: I was checking whether a bug I'd found (no display:inline style on the token div) still existed in 2-3/master. It didn't. But the code was slightly hard to follow, so like a good boy scout, I tidied the campground.
Patch applies to 2-3-stable and master.
-
extra-tags-for-form.patch
2.1 KB
-
Rohit Arondekar- State changed from new to stale
- Importance changed from to
Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.