This project is archived and is in readonly mode.

#3379 ✓stale
Jeffrey Hardy

Tiny refactor of FormTagHelper#extra_tags_for_form

Reported by Jeffrey Hardy | October 15th, 2009 @ 05:45 AM

Tiny refactor of FormTagHelper#extra_tags_for_form

  • removes a dead comment justifying an impossible case
  • pulls out generation of the method/token tags so we can see them
  • switches negative condition in token_tag for readability

Backstory: I was checking whether a bug I'd found (no display:inline style on the token div) still existed in 2-3/master. It didn't. But the code was slightly hard to follow, so like a good boy scout, I tidied the campground.

Patch applies to 2-3-stable and master.

Comments and changes to this ticket

  • Rohit Arondekar

    Rohit Arondekar October 6th, 2010 @ 06:35 AM

    • State changed from “new” to “stale”
    • Importance changed from “” to “”

    Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>