Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

This project is archived and is in readonly mode.

Actionpack 2.3.5 gemspec and Rack requirement don't match

#3558

This commit:

http://github.com/rails/rails/commit/fd0289f3ddf16ca08d6e9510dbf1a7...

bumped the required version of Rack to 1.0.1, but the gemspec only specifies 1.0.0. This can cause problems when installing on a machine with 2.3.2 previously installed, as the Rack 1.0.0 gem is present and satisfies the specified dependency (but blows up when actually starting the app).

Attached single-character patch fixes the actionpack Rakefile to generate a correct specification.

Reported by Matt Jones · December 10th, 2009 @ 06:02 PM

State: resolved
Milestone: 2.3.6
Assigned to: José Valim José Valim
Importance: none

Activity

  1. Matt Jones
    Matt Jones
    • Title changed from Actionpack 23.5 gemspec and Rack requirement don't match to Actionpack 2.3.5 gemspec and Rack requirement don't match

    December 10th, 2009 @ 06:12 PM

  2. Josh Susser
    Josh Susser

    +1

    December 11th, 2009 @ 05:23 AM

  3. Aditya Babbar
    Aditya Babbar

    February 11th, 2010 @ 05:10 AM

  4. Aditya Babbar
    Aditya Babbar

    Sorry, got the link formatting messed up in the above comment.

    February 11th, 2010 @ 05:15 AM

  5. Rizwan Reza
    Rizwan Reza
    • Tag changed from actionpack, bugs, gems to actionpack, bugmash, bugs, gems

    May 16th, 2010 @ 02:41 AM

  6. Bastes
    Bastes

    +1 verified

    Old patch unappliable.

    May 16th, 2010 @ 05:39 PM

  7. Rizwan Reza
    Rizwan Reza
    • Tag changed from actionpack, bugmash, bugs, gems to actionpack, bugs, gems, verified
    • State changed from new to verified

    Bastes gisted a patch. Bumps Rack's version.

    May 16th, 2010 @ 07:47 PM

  8. José Valim
    José Valim
    • Assigned user changed from Jeremy Kemper to José Valim

    We should actually update to Rack 1.1. Can someone update to Rack 1.1 and see if all tests pass?

    May 16th, 2010 @ 07:52 PM

  9. Josh Kalderimis
    Josh Kalderimis

    just against actionpack, or all all tests?

    May 16th, 2010 @ 07:54 PM

  10. Rizwan Reza
    Rizwan Reza

    This one bumps to Rack 1.1. Tests are passing all around here.

    May 16th, 2010 @ 08:02 PM

  11. Rizwan Reza
    Rizwan Reza
    • Tag changed from actionpack, bugs, gems, verified to actionpack, bugmash-review, bugs, gems, verified

    May 16th, 2010 @ 08:03 PM

  12. Rizwan Reza
    Rizwan Reza

    Minor fix, as suggested by José.

    May 16th, 2010 @ 08:11 PM

  13. Rizwan Reza
    Rizwan Reza
    • State changed from verified to resolved

    May 16th, 2010 @ 09:22 PM

  14. Rizwan Reza
    Rizwan Reza
    • Tag changed from actionpack, bugmash-review, bugs, gems, verified to actionpack, bugs, gems, verified

    May 16th, 2010 @ 09:39 PM

  15. TMorgan99
    TMorgan99

    Perhaps a test was missing.
    The upgrade to 1.1.0 appears to break the selenium-client test in some way.
    see #4714 Rails 2.3.8: breaks Selenium test

    May 31st, 2010 @ 01:20 AM