#3558 Actionpack 2.3.5 gemspec and Rack requirement don't match - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3558 ✓resolved

Actionpack 2.3.5 gemspec and Rack requirement don't match

Reported by Matt Jones | December 10th, 2009 @ 06:02 PM | in 2.3.6

This commit:

http://github.com/rails/rails/commit/fd0289f3ddf16ca08d6e9510dbf1a7...

bumped the required version of Rack to 1.0.1, but the gemspec only specifies 1.0.0. This can cause problems when installing on a machine with 2.3.2 previously installed, as the Rack 1.0.0 gem is present and satisfies the specified dependency (but blows up when actually starting the app).

Attached single-character patch fixes the actionpack Rakefile to generate a correct specification.

rakefile_fix.patch 743 Bytes

Comments and changes to this ticket

Matt Jones December 10th, 2009 @ 06:12 PM
- Title changed from “Actionpack 23.5 gemspec and Rack requirement don't match” to “Actionpack 2.3.5 gemspec and Rack requirement don't match”
You flagged this item as spam.
Josh Susser December 11th, 2009 @ 05:23 AM
+1
You flagged this item as spam.
Aditya Babbar February 11th, 2010 @ 05:10 AM
Related Issue: [#3685](/projects/8994/tickets/3685 "Ticket #3685")
You flagged this item as spam.
Aditya Babbar February 11th, 2010 @ 05:15 AM
Sorry, got the link formatting messed up in the above comment.
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag changed from “actionpack, bugs, gems” to “actionpack, bugmash, bugs, gems”
[bulk edit]
You flagged this item as spam.
Bastes May 16th, 2010 @ 05:39 PM
+1 verified

Old patch unappliable.
Rizwan Reza May 16th, 2010 @ 07:47 PM
- Tag changed from “actionpack, bugmash, bugs, gems” to “actionpack, bugs, gems, verified”
- State changed from “new” to “verified”
Bastes gisted a patch. Bumps Rack's version.
- 0001-fixes-rack-dependency-in-2-3-stable.patch 745 Bytes
José Valim May 16th, 2010 @ 07:52 PM
- Assigned user changed from “Jeremy Kemper” to “José Valim”
We should actually update to Rack 1.1. Can someone update to Rack 1.1 and see if all tests pass?
Josh Kalderimis May 16th, 2010 @ 07:54 PM
just against actionpack, or all all tests?
Rizwan Reza May 16th, 2010 @ 08:02 PM
This one bumps to Rack 1.1. Tests are passing all around here.
- 0001-bumps-rack-to-11-tests-passing.patch 1.1 KB
Rizwan Reza May 16th, 2010 @ 08:03 PM
- Tag changed from “actionpack, bugs, gems, verified” to “actionpack, bugmash-review, bugs, gems, verified”
Rizwan Reza May 16th, 2010 @ 08:11 PM
Minor fix, as suggested by José.
- 0001-rack-dependency-bumped-to-110-tests-passing.patch 1.1 KB
Rizwan Reza May 16th, 2010 @ 09:22 PM
- State changed from “verified” to “resolved”
(from [74206aeff2b6a960612a820ec47e91ef9b778262]) Rack dependency bumped to 1.1.0, tests passing. [#3558 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/74206aeff2b6a960612a820ec47e91...
Rizwan Reza May 16th, 2010 @ 09:39 PM
- Tag changed from “actionpack, bugmash-review, bugs, gems, verified” to “actionpack, bugs, gems, verified”
You flagged this item as spam.
TMorgan99 May 31st, 2010 @ 01:20 AM
Perhaps a test was missing.
The upgrade to 1.1.0 appears to break the selenium-client test in some way.
see #4714