#4244 [PATCH] link_to :remote => false does not work - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4244 ✓resolved

[PATCH] link_to :remote => false does not work

Reported by foca | March 20th, 2010 @ 08:59 PM | in 3.0.2

link_to ignores the value of the :remote option, only taking into account if the option is there or not. This patch adds the ability to pass :remote => false in order to decide at runtime if you want the link to be javascript or not.

0001-allow-passing-remote-false-to-links.patch 2.1 KB

Comments and changes to this ticket

You flagged this item as spam.
foca March 20th, 2010 @ 09:06 PM
- Tag changed from “action_view helper patch” to “action_view, helper, patch”
Yehuda Katz (wycats) March 27th, 2010 @ 08:22 AM
- State changed from “new” to “incomplete”
- Assigned user set to “Yehuda Katz (wycats)”
- Milestone cleared.
Shouldn't this also work for other remote types like form_for :remote => false?
Yehuda Katz (wycats) March 27th, 2010 @ 08:22 AM
- Tag changed from “action_view, helper, patch” to “action_view, helper, patch, rails3”
You flagged this item as spam.
foca March 27th, 2010 @ 06:52 PM
It already works for button_to and form_tag, only link_to was missing.
You flagged this item as spam.
foca March 27th, 2010 @ 06:53 PM
Should I add tests for those too, so we don't get a regression?
You flagged this item as spam.
foca April 15th, 2010 @ 01:47 AM
Er, I completely forgot about this, sorry :*
- 0001-allow-remote-false-to-be-passed-to-link_to.patch 3.4 KB
Dan Pickett April 21st, 2010 @ 01:54 AM
+1 verified the latest patch applies cleanly and results in the intended behavior. New tests were added to ensure no regression took place

bostonrb
Neeraj Singh April 29th, 2010 @ 11:07 AM
+1 verified the patch
Yehuda Katz (wycats) May 4th, 2010 @ 05:24 PM
- State changed from “incomplete” to “resolved”
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]