Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• 

  Jeremy Kemper April 7th, 2010 @ 06:36 PM

  • State changed from “new” to “open”
  • Assigned user set to “Jeremy Kemper”
  • Milestone cleared.

  We need to solve this at the Rack level by having a middleware force_encoding on incoming params and headers.

• You flagged this item as spam.
  

  Szymon Nowak April 8th, 2010 @ 12:08 PM

  In our projects (Rails 2.3.5) we're currently using something like this to solve the problem with params:

    before_filter :force_utf8_params
    
    def force_utf8_params
      traverse = lambda do |object, block|
        if object.kind_of?(Hash)
          object.each_value { |o| traverse.call(o, block) }
        elsif object.kind_of?(Array)
          object.each { |o| traverse.call(o, block) }
        else
          block.call(object)
        end
        object
      end
      force_encoding = lambda do |o|
        o.force_encoding(Encoding::UTF_8) if o.respond_to?(:force_encoding)
      end
      traverse.call(params, force_encoding)
    end
  

  but we want to move it into a middleware as well.

• You flagged this item as spam.
  

  Marcin Kulik May 12th, 2010 @ 10:32 AM

  Jeremy, I think this middleware should not blindly do force_encoding("utf8") because browser could send data in other encoding without telling which. It could be really in ISO-8859-1 and forcing UTF8 will damage the string. Maybe the middleware should use some heuristics to guess encoding if HTTP encoding header wasn't set. Wycats wrote in one if his recent posts that there are some ideas for such a middleware. Do you know if anyone tried to do sth with it?
  I'm willing to help as this is real PITA for me at the moment.

• 

  Dan Pickett May 15th, 2010 @ 01:48 AM

  • Tag changed from “encoding, rails3, ruby19, utf8” to “bugmash, encoding, rails3, ruby19, utf8”

• You flagged this item as spam.
  

  Sasha Koss May 21st, 2010 @ 03:15 AM

  @Szymon Nowak

  Thanks! It works fine for me!

• You flagged this item as spam.
  

  Marcin Kulik May 31st, 2010 @ 02:23 PM

  @Szymon

  Thanks! It works pretty well so far.

• You flagged this item as spam.
  

  David Morton June 21st, 2010 @ 10:59 PM

  My first attempt at creating a rails 3 project hit this one. @Szymon solution works, if a bit hackish. :)

• 

  Rohit Arondekar July 4th, 2010 @ 02:59 AM

  • State changed from “open” to “duplicate”
  • Importance changed from “” to “Low”

  I think this issue was resolved in this ticket https://rails.lighthouseapp.com/projects/8994/tickets/4807

  Can you please confirm? If there are still issues that remain then can you continue the discussion on that ticket?

• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”

  [bulk edit]