This project is archived and is in readonly mode.
echoing to stdin for mysql truncates queries on Windows
C:\projects\rails\activerecord>rake mysql:build_databases
(in C:/projects/rails/activerecord)
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server v
ersion for the right syntax to use near '"create DATABASE activerecord_unittest DEFAULT CHARACTER SET utf8 DEFAULT COLLAT' a
t line 1
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server v
ersion for the right syntax to use near '"create DATABASE activerecord_unittest2 DEFAULT CHARACTER SET utf8 DEFAULT COLLA' a
t line 1
This appears to be due to echo also outputting the quote characters on Windows.
The fix, however, is simple and completely cross-platform. Patch attached.
-
no_more_echo.diff
888 Bytes
-
-
David Trasbo- Importance changed from to Low
+1 Perfectly sane, as Ryan puts it.
The patch no longer applies cleanly, though. Could you update it, Greg? I think if you assign it to José Valim afterwards, he'll include it.
-
Greg Hazel- Assigned user set to José Valim
The patch still applies cleanly for me...
Here's another, against http://github.com/rails/rails/blob/master/activerecord/Rakefile right this moment.
-
no_more_echo2.diff
888 Bytes
-
David Trasbo
Surely you remembered to do a
git pullbefore trying to apply the patch, right? -
Greg Hazel
It was a fresh checkout..
-
José ValimGreg, could you please supply a patch according to the conventions outline here: http://rails.lighthouseapp.com/projects/8994/sending-patches ?
Thanks.
-
-
Repository- State changed from open to resolved
(from [3f49456f5b79d9701d8caeaa653477337f8771de]) remove use of echo [#4410 echoing to stdin for mysql truncates queries on Windows state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/3f49456f5b79d9701d8caeaa653477...