This project is archived and is in readonly mode.
echoing to stdin for mysql truncates queries on Windows
Reported by Greg Hazel | April 16th, 2010 @ 01:33 AM
C:\projects\rails\activerecord>rake mysql:build_databases
(in C:/projects/rails/activerecord)
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server v
ersion for the right syntax to use near '"create DATABASE activerecord_unittest DEFAULT CHARACTER SET utf8 DEFAULT COLLAT' a
t line 1
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server v
ersion for the right syntax to use near '"create DATABASE activerecord_unittest2 DEFAULT CHARACTER SET utf8 DEFAULT COLLA' a
t line 1
This appears to be due to echo also outputting the quote characters on Windows.
The fix, however, is simple and completely cross-platform. Patch attached.
Comments and changes to this ticket
-
Ryan Bigg April 16th, 2010 @ 01:37 AM
- State changed from new to open
+1 Patch is sane and applies cleanly.
-
David Trasbo August 8th, 2010 @ 04:30 PM
- Importance changed from to Low
+1 Perfectly sane, as Ryan puts it.
The patch no longer applies cleanly, though. Could you update it, Greg? I think if you assign it to José Valim afterwards, he'll include it.
-
Greg Hazel August 8th, 2010 @ 04:50 PM
- Assigned user set to José Valim
The patch still applies cleanly for me...
Here's another, against http://github.com/rails/rails/blob/master/activerecord/Rakefile right this moment.
-
David Trasbo August 8th, 2010 @ 04:54 PM
Surely you remembered to do a
git pull
before trying to apply the patch, right? -
José Valim September 1st, 2010 @ 08:40 AM
Greg, could you please supply a patch according to the conventions outline here: http://rails.lighthouseapp.com/projects/8994/sending-patches ?
Thanks.
-
Repository September 2nd, 2010 @ 10:55 AM
- State changed from open to resolved
(from [3f49456f5b79d9701d8caeaa653477337f8771de]) remove use of echo [#4410 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/3f49456f5b79d9701d8caeaa653477...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 4410 echoing to stdin for mysql truncates queries on Windows (from [3f49456f5b79d9701d8caeaa653477337f8771de]) remove ...