This project is archived and is in readonly mode.
ActiveSupport::Notifications.unsubscribe("by name") does not remove subscription
Reported by David Chelimsky | April 18th, 2010 @ 06:24 AM
ActiveSupport::Notifications::Fanout#unsubscribe
assumes it is given a subscription object, but
ActionController::TestCase#teardown_subscriptions
passes it a String, so the subscription is never removed.
Patch: http://github.com/dchelimsky/rails/commit/3bd7148e63117517c1d7f21f0...
Comments and changes to this ticket
-
David Chelimsky April 18th, 2010 @ 06:26 AM
- Tag set to “patch, test”
-
David Chelimsky April 18th, 2010 @ 06:26 AM
- Assigned user set to “Yehuda Katz (wycats)”
-
David Chelimsky April 18th, 2010 @ 07:22 AM
Related, teardown_subscriptions does not tear down both of the subscriptions that are set up in setup_subscriptions. Patch: http://github.com/dchelimsky/rails/commit/46798ec96e5b646ff69667c10...
-
David Chelimsky April 25th, 2010 @ 03:15 AM
The previous patch was incomplete. This one improves the tests and code:
http://github.com/dchelimsky/rails/commit/f0d1b1db89942a1e0b10df617...
-
Repository April 25th, 2010 @ 06:07 AM
- State changed from “new” to “resolved”
(from [864bd9c21fdc8ce265c48fdfa2d4d7917032e717]) allow unsubscribe by name or subscription [#4433 state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/864bd9c21fdc8ce265c48fdfa2d4d7... -
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
David Chelimsky
Yehuda Katz (wycats)
Referenced by
-
4433
ActiveSupport::Notifications.unsubscribe("by name") does not remove subscription
(from [864bd9c21fdc8ce265c48fdfa2d4d7917032e717])
allow u...