#4558 sending :alt => nil to an image tag should omit the images alt tag - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4558 ✓resolved

sending :alt => nil to an image tag should omit the images alt tag

Reported by Jeff Dean | May 9th, 2010 @ 06:08 AM | in 3.0.2

I have an app where I set the alt tag of images with javascript. To reduce the size of the page, I want to emit img tags with no alt attribute, however that is not currently possible:

image_tag "foo.png", :alt => nil # => <img alt="Foo" src="/images/foo.png" />

I agree that images should have alt tags, and I agree that the default is sensible. However, if I explicitly send :alt => nil, I expect it to omit the alt attribute altogether, to be consistent with :class and other html attributes.

I plan to submit a patch momentarily.

Comments and changes to this ticket

You flagged this item as spam.
Jeff Dean May 9th, 2010 @ 06:10 AM
Here's a patch that fixes it, with a test.
- nil-alt-tag.diff 2.4 KB
You flagged this item as spam.
Jeff Dean May 9th, 2010 @ 06:10 AM
- Tag changed from “action_view” to “action_view, patch”
You flagged this item as spam.
Mislav May 9th, 2010 @ 03:27 PM
+1 for teaching me about Hash#fetch
Dan Pickett May 9th, 2010 @ 05:51 PM
- Tag changed from “action_view, patch” to “action_view, bugmash, patch”
You flagged this item as spam.
Anthony Burns May 9th, 2010 @ 06:42 PM
+1 for teaching me Hash#fetch as well
You flagged this item as spam.
Marc-André Lafortune May 9th, 2010 @ 09:19 PM
Hi Jeff!

I'd recommend using the block form of fetch, to avoid an unnecessary calculation in case the :alt option is specified. Modified diff attached.
You flagged this item as spam.
Marc-André Lafortune May 9th, 2010 @ 09:19 PM
Let's try the attachment again...
- nil-alt-tag-2.diff 1.9 KB
You flagged this item as spam.
Jeff Dean May 10th, 2010 @ 02:36 AM
- Tag cleared.
And thanks for Marc-Andre for introducing me to fetch last year! I forgot about the block syntax.
Josh Kalderimis May 10th, 2010 @ 11:09 AM
+1

Handy addition
José Valim May 10th, 2010 @ 11:12 AM
- Milestone cleared.
- Assigned user set to “José Valim”
You flagged this item as spam.
Tony Pitale May 10th, 2010 @ 05:35 PM
+1 would be nice, definitely had this minor annoyance.
Repository May 15th, 2010 @ 08:51 AM
- State changed from “new” to “resolved”
(from [9869ee77cdbf8f0e9c7eb6e33738d0aa8f5dc70a]) Accept :alt => nil on image_tag [#4558 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/9869ee77cdbf8f0e9c7eb6e33738d0...
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Tag set to “3, documentation, patch, review”
- Milestone set to “3.0.2”
[bulk edit]