This project is archived and is in readonly mode.
[PATCH] Added nokogiri dependency to Gemfile
Currently trying to solve ticket #3205 and I found out Gemfile is missing nokogiri dependency, so nokogiri tests are happily skipped :-). I've attached a patch.
PS. I'll add bugmash-review tag right away cos it's a very quick fix imho.
-
Anil WadghuleDoesn't adding nokogiri in Gemfile create problem with JRuby tests. Thoughts?
-
Priit TamboomIt shouldn't affect jruby cos I added it to dependency group :mri
-
Priit Tamboom
- Tag changed from gemfile bugmash bugmash bugmash-review to bugmash, gemfile, nokogiri
- Assigned user set to Rizwan Reza
I tried jruby with rvm and failed to run "bundler install" at the moment (with or without nokogiri dependency). I'm not much jruby expert at the moment.
-
Priit Tamboom
- Assigned user cleared.
-
Wijnand Wiersma+1 And it does not fail on jruby for me.
-
Repository
- State changed from new to resolved
(from [f8432108e85c06ab8939869ece0297e72c21e7fe]) Added nokogiri dependency to Gemfile [#4617 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f8432108e85c06ab8939869ece0297... -
José Valim- Tag changed from bugmash, gemfile, nokogiri to gemfile, nokogiri