This project is archived and is in readonly mode.
[PATCH] Added nokogiri dependency to Gemfile
Reported by Priit Tamboom | May 16th, 2010 @ 02:18 PM
Currently trying to solve ticket #3205 and I found out Gemfile is missing nokogiri dependency, so nokogiri tests are happily skipped :-). I've attached a patch.
PS. I'll add bugmash-review tag right away cos it's a very quick fix imho.
Comments and changes to this ticket
-
Anil Wadghule May 16th, 2010 @ 02:30 PM
Doesn't adding nokogiri in Gemfile create problem with JRuby tests. Thoughts?
-
Priit Tamboom May 16th, 2010 @ 02:43 PM
It shouldn't affect jruby cos I added it to dependency group :mri
-
Priit Tamboom May 16th, 2010 @ 03:47 PM
- Tag changed from “gemfile bugmash bugmash bugmash-review” to “bugmash, gemfile, nokogiri”
- Assigned user set to “Rizwan Reza”
I tried jruby with rvm and failed to run "bundler install" at the moment (with or without nokogiri dependency). I'm not much jruby expert at the moment.
-
Priit Tamboom May 16th, 2010 @ 04:04 PM
- Assigned user cleared.
-
-
Repository May 16th, 2010 @ 07:34 PM
- State changed from “new” to “resolved”
(from [f8432108e85c06ab8939869ece0297e72c21e7fe]) Added nokogiri dependency to Gemfile [#4617 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f8432108e85c06ab8939869ece0297... -
José Valim May 16th, 2010 @ 07:35 PM
- Tag changed from “bugmash, gemfile, nokogiri” to “gemfile, nokogiri”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Priit Tamboom
Attachments
Referenced by
-
4617
[PATCH] Added nokogiri dependency to Gemfile
(from [f8432108e85c06ab8939869ece0297e72c21e7fe])
Added n...