#4955 reduce usage of Pathname to make things faster - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4955 ✓invalid

reduce usage of Pathname to make things faster

Reported by Neeraj Singh | June 24th, 2010 @ 01:30 PM | in 3.x

Neeraj Singh June 24th, 2010 @ 04:25 PM
- Tag changed from “rails3” to “patch, rails3”
- Assigned user set to “José Valim”
Attached is code patch.
- 4955_fix.diff 830 Bytes
You flagged this item as spam.
Jason Gignac June 24th, 2010 @ 04:51 PM
I am only curious, but why is pathname slower than the alternative implementation that is in the original commit and that you suggest in your diff here?
José Valim June 24th, 2010 @ 04:55 PM
Jason, doing operations in Pathname objects is expensive. If you run some benchmarks, you can see the difference!
José Valim June 24th, 2010 @ 07:15 PM
- State changed from “new” to “invalid”
Neeraj, in this case it would be better if the method returned a pathname object for both windows and other platforms, for consistency. And your patch breaks that, so I cannot apply it. :(

I think there is no reason to worry with remaining Pathnames in Rails though, the ones that were appearing in profiling and benchmarks were already removed! Thanks!