This project is archived and is in readonly mode.
Action Pack test suite: "uninitialized constant Test::Unit::AssertionFailedError"
Reported by David Trasbo | June 26th, 2010 @ 09:35 PM | in 3.0.2
It seems that Rails uses the MiniTest implementation of
Test::Unit in some cases, and the standard implementation in others
- I haven't been able to work out how that works, but the fact of
the matter is: A test in the Action Pack suite fails because it
references Test::Unit::AssertionFailedError
even
though it might not exist.
I'm attaching a patch in a minute that changes the test to
reference the generic
ActiveSupport::TestCase::Assertion
which changes
depending on which Test::Unit
implementation is
used.
Comments and changes to this ticket
-
David Trasbo June 26th, 2010 @ 09:37 PM
- no changes were found...
-
Rohit Arondekar June 27th, 2010 @ 02:04 AM
- Tag set to rails 3, actionpack, patch, tests
- State changed from new to verified
- Milestone cleared.
- Importance changed from to Low
+1 Applies cleanly, tests pass on 1.8.7, 1.9.2 (head and preview3) and is the correct fix.
Note that this leaves one failing test on 1.9.2(head & preview3) as reported here #4965
-
Repository June 27th, 2010 @ 02:45 AM
(from [0abf4b07462d4383691581bc38cd6bf1b5887281]) Change reference to Test::Unit::AssertionFailedError to the generic ActiveSupport::TestCase::Assertion [#4987 state:commited]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/0abf4b07462d4383691581bc38cd6b... -
Rohit Arondekar June 27th, 2010 @ 02:54 AM
- State changed from verified to committed
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 4987 Action Pack test suite: "uninitialized constant Test::Unit::AssertionFailedError" (from [0abf4b07462d4383691581bc38cd6bf1b5887281]) Change ...