Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Action Pack test suite: "uninitialized constant Test::Unit::AssertionFailedError"

#4987

It seems that Rails uses the MiniTest implementation of Test::Unit in some cases, and the standard implementation in others - I haven't been able to work out how that works, but the fact of the matter is: A test in the Action Pack suite fails because it references Test::Unit::AssertionFailedError even though it might not exist.

I'm attaching a patch in a minute that changes the test to reference the generic ActiveSupport::TestCase::Assertion which changes depending on which Test::Unit implementation is used.

Reported by David Trasbo · June 26th, 2010 @ 09:35 PM

State: committed
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. David Trasbo
    David Trasbo

    June 26th, 2010 @ 09:37 PM

  2. Rohit Arondekar
    Rohit Arondekar
    • Tag set to rails 3, actionpack, patch, tests
    • State changed from new to verified
    • Milestone cleared.
    • Importance changed from to Low

    +1 Applies cleanly, tests pass on 1.8.7, 1.9.2 (head and preview3) and is the correct fix.

    Note that this leaves one failing test on 1.9.2(head & preview3) as reported here #4965 2 failures in Action Pack in master on 1.9.2-head

    June 27th, 2010 @ 02:04 AM

  3. Repository
    Repository

    (from [0abf4b07462d4383691581bc38cd6bf1b5887281]) Change reference to Test::Unit::AssertionFailedError to the generic ActiveSupport::TestCase::Assertion [#4987 Action Pack test suite: "uninitialized constant Test::Unit::AssertionFailedEr... state:commited]

    Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
    http://github.com/rails/rails/commit/0abf4b07462d4383691581bc38cd6b...

    June 27th, 2010 @ 02:45 AM

  4. Rohit Arondekar
    Rohit Arondekar
    • State changed from verified to committed

    June 27th, 2010 @ 02:54 AM

  5. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2

    October 15th, 2010 @ 11:01 PM