This project is archived and is in readonly mode.
ActiveResource load problem with array of booleans
Hi,
I have resource which returns array of booleans and ActiveResource
cannot load it. I found that code for array in
ActiveResource::Base.load is not smart enought. I think that only
valid arguments to new activeResource is Hash, os for me is better
to test if element of array is hash instead of trying to catch some
cases which is not Hash.
my proposed fix is attached together with testing xml and test (maybe element name is not correct)
-
test.rb
311 Bytes
-
tmp.xml
726 Bytes
-
rails-activeresource-load.patch
629 Bytes
-
José Valim- State changed from new to incomplete
- Importance changed from to Low
Nice, could you please provide a patch with tests following the conventions outline here: http://rails.lighthouseapp.com/projects/8994/sending-patches ?
Thanks!
-
Josef ReidingerAttached patch with test following conventions. If you find any problem feel free to ask me
-
José Valim
- State changed from incomplete to open
Josef, I'm sorry but your patch no longer apply! Could you please rebase it? Thanks!
-
Josef Reidinger
Of course, here it is. Just note, that it is patch against 2-3-branch.
-
José Valim
Ahhh, it is for 2-3-stable branch? Would you mind providing a patch for 3.0 as well?
-
Josef Reidinger
OK, here it is, but due to changes in rails 3 I cannot run test suite, so please try run tests before submit ( I have installed gems for 2.3.8 app development ).
-
José Valim
Patch does not apply for Rails master. :(
-
Josef Reidinger
Oh, sorry. I still don't have enough practice in creating patches in correct branch. Here is correct one.
-
Repository
- State changed from open to resolved
(from [59693c4c49cce5e4cf53eb54e42e3da07a98467e]) fix loading of different elements in array then int and string [#5036 ActiveResource load problem with array of booleans state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/59693c4c49cce5e4cf53eb54e42e3d...