This project is archived and is in readonly mode.
ActiveResource load problem with array of booleans
Reported by Josef Reidinger | July 2nd, 2010 @ 02:32 PM
Hi,
I have resource which returns array of booleans and ActiveResource
cannot load it. I found that code for array in
ActiveResource::Base.load is not smart enought. I think that only
valid arguments to new activeResource is Hash, os for me is better
to test if element of array is hash instead of trying to catch some
cases which is not Hash.
my proposed fix is attached together with testing xml and test (maybe element name is not correct)
Comments and changes to this ticket
-
José Valim July 8th, 2010 @ 10:20 PM
- State changed from “new” to “incomplete”
- Importance changed from “” to “Low”
Nice, could you please provide a patch with tests following the conventions outline here: http://rails.lighthouseapp.com/projects/8994/sending-patches ?
Thanks!
-
Josef Reidinger July 15th, 2010 @ 11:37 AM
Attached patch with test following conventions. If you find any problem feel free to ask me
-
José Valim July 18th, 2010 @ 10:31 AM
- State changed from “incomplete” to “open”
Josef, I'm sorry but your patch no longer apply! Could you please rebase it? Thanks!
-
Josef Reidinger July 19th, 2010 @ 08:19 AM
Of course, here it is. Just note, that it is patch against 2-3-branch.
-
José Valim July 19th, 2010 @ 02:30 PM
Ahhh, it is for 2-3-stable branch? Would you mind providing a patch for 3.0 as well?
-
Josef Reidinger July 19th, 2010 @ 02:45 PM
OK, here it is, but due to changes in rails 3 I cannot run test suite, so please try run tests before submit ( I have installed gems for 2.3.8 app development ).
-
-
Josef Reidinger July 27th, 2010 @ 08:57 AM
Oh, sorry. I still don't have enough practice in creating patches in correct branch. Here is correct one.
-
Repository August 2nd, 2010 @ 04:10 PM
- State changed from “open” to “resolved”
(from [59693c4c49cce5e4cf53eb54e42e3da07a98467e]) fix loading of different elements in array then int and string [#5036 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/59693c4c49cce5e4cf53eb54e42e3d...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Josef Reidinger
Attachments
Tags
Referenced by
-
5036
ActiveResource load problem with array of booleans
(from [59693c4c49cce5e4cf53eb54e42e3da07a98467e])
fix loa...