This project is archived and is in readonly mode.
Recent named_scope STI fix causes a massive slow down and memory leak
Commit 687d7f52c4a1d85666f1efc08ffa182e6dfeba57 (against 2-3-stable) from ticket #1570 named_scope not preserving proper model in STI is flawed and causes a massive slow down and memory leak. This caused my server to eat up all its RAM and swap before falling into a coma.
It's a fix to ensure that procs passed to named_scope are given
the correct model when using STI. The "scoped" method uses a
named_scope attached to ActiveRecord::Base so the
self.model_name != parent_scope.model_name condition
is always true in this case.
Here is a patch that checks to ensure self != Base
but I'm wondering if this whole thing would still cause problems
even when used in the right cases. Maybe the original commit should
just be reverted?
-
James Le Cuirot- Tag changed from activerecord 2-3-stable named_scope scoped memory leak patch to leak patch, 2-3-stable, activerecord, memory, named_scope, scoped
-
James Le Cuirot
- Tag changed from leak patch, 2-3-stable, activerecord, memory, named_scope, scoped to memory leak, 2-3-stable, activerecord, named_scope, patch, scoped
-
-
James Le Cuirot
1.8.7.
(sorry, had a fight with the tagger)
-
Repository- State changed from new to resolved
(from [bfbdeeae3080c89a0b27e42d684cbeb6206c6f60]) Use bind instead of instance_exec cause it may be causing memory leaks. Also, provide a simpler and sane implementation for scoped. [#5044 Recent named_scope STI fix causes a massive slow down and memory leak state:resolved] http://github.com/rails/rails/commit/bfbdeeae3080c89a0b27e42d684cbe...
-
Logan BowersThis commit regressed scoped() functionality, please see bug #5915 New "scoped" implementation since v2.3.9 breaks chained scopes with custom me...