named_scope not preserving proper model in STI

Loading development environment (Rails 2.3.0)
>> Employee.simple_test(123)
User(id: integer, created_at: datetime, updated_at: datetime, active: boolean, type: string, location_id: integer, name: string, email: string)
=> []

class Employee < User
end

And because it's bit late, i did typo in example code :(

This is not so much named_scope doing something but ruby closures. The block associated with the lambda remembers what self was when that block was made.

Yup, i figured out that. But still, problem exists. Workaround could be redefine simple_test from Employee method, but we do STI to be DRY, this is not DRY. The best solution would be Proc#call_with_binding in Ruby (hard thing!) or rework of scopes, and create some helper method for all lambdas.

For Proc#call_with_binding... well it's funny but we have some similar proposals for 1.9? http://www.ruby-forum.com/topic/...

The second solution would be probably very ugly and no one from core will acceppt such and api for lambdas ? Am i right ?

Or if the @proxy_scope variable from the Scope (which should be the "right" class/scope) were somehow passed to the lambda, but I'm not sure how you'd do that without breaking everyone's existing code.

I hoped that solution will be easy, and i was right :) Active Support gives us Proc#bind that emulates 1.9 instance_exec (instance_eval with arguments)

It was after i post proposal http://www.ruby-forum.com/topic/..., details about instance_exec you can found here http://eigenclass.org/hiki.rb?in...

I thnik DHH and rest of core should lobby ruby-core for Proc#bind native implementation in 1.9, it's better to have it in ruby than in active_support just like Symbol#to_proc. Just use your power that comes from being core of ruby community ;-)

Small patch with testcase is on the way.

And here it is.

Same stuff but here i'm using instance_exec functionality.

Here is test.

(from [687d7f52c4a1d85666f1efc08ffa182e6dfeba57]) STI should identify itself inside named_scope

[#1570 named_scope not preserving proper model in STI state:resovled]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/687d7f52c4a1d85666f1efc08ffa18...