#5336 AssociationCollection#include? ignoring build associated objects (not working in Rails 3) - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5336 ✓committed

AssociationCollection#include? ignoring build associated objects (not working in Rails 3)

Reported by Marcelo Giorgi | August 8th, 2010 @ 07:46 PM | in 3.0.2

Hi,

I've been working on ticket #3742 for Rails 2.3.x, but I've noticed this is happening on Rails 3.x version too.

So, I've ported the same fix (that applies cleanly on master) here, let me know if you got any suggestion.

assoc-collection-includes-not-ignoring-object-added-by-build.diff 4.6 KB

Comments and changes to this ticket

You flagged this item as spam.
Marcelo Giorgi September 4th, 2010 @ 04:01 PM
Here I attach a minor semantic change on the patch (I was using #map, where I should use #each)
- 0001-associationcollection-include-working-properly-for-o.patch 4.6 KB
Santiago Pastorino September 28th, 2010 @ 07:20 PM
- State changed from “new” to “open”
- Milestone cleared.
- Assigned user set to “Aaron Patterson”
- Importance changed from “” to “Low”
Aaron Patterson September 30th, 2010 @ 06:32 PM
@Marcelo do you mind rebasing this patch against 3-0-stable? Then I'll apply it.

Thanks!
You flagged this item as spam.
Marcelo Giorgi September 30th, 2010 @ 07:36 PM
Here it is, I've just tested and applies cleanly on master.

Thank you very much!
- 0001-associationcollection-include-working-properly-for-o.patch 4.7 KB
Jeremy Kemper October 15th, 2010 @ 11:02 PM
- Milestone set to “3.0.2”
[bulk edit]
Aaron Patterson October 21st, 2010 @ 01:27 AM
Can you rebase this against master? Then I'll apply. Thanks!
You flagged this item as spam.
Marcelo Giorgi October 22nd, 2010 @ 12:32 PM
Hi Aaron,

Seems like you already applied it: http://github.com/rails/rails/commit/ef6df93a8ddb675f1298973bb34782...

I guess, that the reason for this ticket not to be closed, is because I put the wrong ticket number on the commit's comment :P. So, perhaps we can close this one manually.

BTW: Thanks for applying this!
Santiago Pastorino October 22nd, 2010 @ 01:19 PM
- State changed from “open” to “committed”