This project is archived and is in readonly mode.
AssociationCollection#include? ignoring build associated objects (not working in Rails 3)
Hi,
I've been working on ticket #3742 Remove remaining references to script/plugin sources for Rails 2.3.x, but I've noticed this is happening on Rails 3.x version too.
So, I've ported the same fix (that applies cleanly on master) here, let me know if you got any suggestion.
-
Marcelo GiorgiHere I attach a minor semantic change on the patch (I was using #map, where I should use #each)
-
Santiago Pastorino- State changed from new to open
- Milestone cleared.
- Assigned user set to Aaron Patterson
- Importance changed from to Low
-
Aaron Patterson@Marcelo do you mind rebasing this patch against 3-0-stable? Then I'll apply it.
Thanks!
-
Marcelo Giorgi
Here it is, I've just tested and applies cleanly on master.
Thank you very much!
-
-
Aaron Patterson
Can you rebase this against master? Then I'll apply. Thanks!
-
Marcelo Giorgi
Hi Aaron,
Seems like you already applied it: http://github.com/rails/rails/commit/ef6df93a8ddb675f1298973bb34782...
I guess, that the reason for this ticket not to be closed, is because I put the wrong ticket number on the commit's comment :P. So, perhaps we can close this one manually.
BTW: Thanks for applying this!
-
Santiago Pastorino
- State changed from open to committed