This project is archived and is in readonly mode.
[PATCH] Changes in autoload and some minor fixes
-
Łukasz Strzałkowski- Title changed from Changes in autoload and some minor fixes to [PATCH] Changes in autoload and some minor fixes
- Tag set to autoload, patch
-
José Valim- Milestone set to 3.1
- Importance changed from to Low
I will apply your changes later when we release Rails 3 final to avoid making big changes in the code now.
-
Łukasz Strzałkowski
I did some cleaning on my branch recently. All changes for this ticket you can now find under branch autoload in my fork: http://github.com/strzalek/rails/commits/autoload
-
José Valim
- State changed from new to resolved
Applied, except the one which remove a few errors since they are probably used by plugins/extensions.
-
Łukasz Strzałkowski
Thanks.
I didn't catch this becouse I wasn't even looking after this. Thought that if it is not used in core than no body care about it ;-)
-
José Valim
Your changes broke the booting of a new rails 3 app. Could you please
investigate or should I revert? -
Łukasz Strzałkowski
Jose,
Sorry for that. When I was doing this change, I looked carefuly on tests and tried some sample app. Everything was okay.
I've just pulled the newest revision of master, and fired it up with new, clean, rails 3 app without any problem.
Please revert this if it's breaking booting process and if you can provide some feedback how to reproduce it, along with what error is raised during the booting I would be thankful.
Sorry about that one more time. I will try to fix it as soon as I reprodcue it, for now I think it should be reverted as it huge blocker.
-
Łukasz Strzałkowski
Ok, I've found the error, I'll try fix it quickly.
-
Łukasz Strzałkowski
Please revert it for now.
I have some freaking problems with gems and rvm localy and I'm unable to fix it now.
-
Repository- State changed from resolved to open
(from [599e46bf24419a429ee0bb0ea02afd48f47aa4ec]) Revert "Setup explicit requires for files with exceptions. Removed them from autoloading."
Booting a new Rails application does not work after this commit [#5359 [PATCH] Changes in autoload and some minor fixes state:open]
This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
http://github.com/rails/rails/commit/599e46bf24419a429ee0bb0ea02afd... -
José Valim
Reverted! Waiting for a new patch! :)
-
Santiago Pastorino
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale