#5436 RC1 to RC2 regression : multilines where conditions autojoin with "AND" - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5436 ✓duplicate

RC1 to RC2 regression : multilines where conditions autojoin with "AND"

Reported by Nicolas Blanco | August 24th, 2010 @ 10:57 AM

Hi,

the behaviour when using multilines where conditions is different between Rails 3 RC1 and Rails 3 RC2.

class User < ActiveRecord::Base
    scope :test_scope,
               where("active = ?
                      and login like ?", true, "%test%")
end

$-> rails c
Loading development environment (Rails 3.0.0.rc)
irb(main):001:0> User.test_scope.to_sql
"SELECT     \"users\".* FROM       \"users\" WHERE     (active = 't'\n                      and login like '%test%')"

$-> rails c
Loading development environment (Rails 3.0.0.rc2)
irb(main):001:0> User.test_scope.to_sql
"SELECT     \"users\".* FROM       \"users\"  WHERE     (active = 't'\n AND                       and login like '%test%')"

As you can see in RC2, it autojoins split lines with "AND" and results in faulty SQL.

Comments and changes to this ticket

oleg dashevskii August 24th, 2010 @ 01:40 PM

Got bitten by it too. Quick workaround is to add backslash:

class User < ActiveRecord::Base
    scope :test_scope,
               where("active = ? \
                      and login like ?", true, "%test%")
end

You flagged this item as spam.
Brandon Tilley August 24th, 2010 @ 04:34 PM
It appears that this only happens for certain adapters. In particular, I did not have this problem on my local development machine using SQLite, but when I pushed to Heroku (which uses PostgreSQL) the bug manifested itself.
You flagged this item as spam.
Thong Kuah August 24th, 2010 @ 11:12 PM
- Tag changed from “arel activerecord bug rails3, activerecord, arel, rails3” to “arel activerecord bug rails3, line break, activerecord, arel, rails3”
You flagged this item as spam.
Thong Kuah August 24th, 2010 @ 11:13 PM
- Tag changed from “arel activerecord bug rails3, line break, activerecord, arel, rails3” to “arel activerecord bug rails3, line break, activerecord, arel, multiline, rails3”
You flagged this item as spam.
oleg dashevskii August 25th, 2010 @ 06:09 AM
So, the bug confirmed with MySQL and PostgreSQL adapters.
You flagged this item as spam.
oleg dashevskii August 26th, 2010 @ 03:32 AM
Duplicate of #5457
Rohit Arondekar August 26th, 2010 @ 03:50 AM
- State changed from “new” to “duplicate”
- Importance changed from “” to “Low”
You flagged this item as spam.
Anil Wadghule October 12th, 2010 @ 09:10 AM
- Tag cleared.
Automatic cleanup of spam.
Aditya Sanghi October 12th, 2010 @ 10:15 AM
Automatic cleanup of spam.