scopes using `reorder` don't override `default_scope` order

Thanks for the quick review. I guess my view would be that the "shipped" API in v3.0 should be honoured, and I'm pretty sure that this behaviour was introduced accidentally...

Actually, reorder should always override the default scope. The current state is definitely a bug.

Sadly, there is still an issue - at least, I think there is - if you have multiple scopes chained, like so:

class Foo < ActiveRecord::Base
    default_scope order('id')
    scope :name_is_nil, where(:name => nil)
    scope :name_order, reorder('name')
    scope :age_order, reorder('age')
end

Foo.name_order.age_order

You will get SQL like:

SELECT * FROM foos ORDER BY name, age

Where I would expect:

SELECT * FROM foos ORDER BY age

i.e. that the last reorder scope in the chain would take precedence.

Also, the current behaviour will produce:

Foo.name_order.name_is_nil.age_order.to_sql # => "SELECT * FROM foos ORDER BY name, id, age"