Rails Ruby on Rails → 3.1

Comments and changes to this ticket

• 

  Santiago Pastorino February 6th, 2011 @ 09:14 PM

  • State changed from “new” to “open”
  • Milestone set to “3.1”
  • Importance changed from “” to “Low”

  Can you provide a test case?

• You flagged this item as spam.
  

  Alex Tambellini February 6th, 2011 @ 10:10 PM

  Attached is a rails app that demonstrates the bug:

  It has a html controller with an index action and a post action.

  The index action renders 2 forms that use :remote => true.

  Both forms submit to the post action with the accept header containing /. However, only the form that includes :"data-type" => "html" succeeds.

  Just start the app (rails 3.0.3) and go to localhost:3000 and then click on "Submit With Data Type" and "Submit Without Data Type" buttons to see the behavior described above.

  • accept_header_test.zip 126.9 KB

• You flagged this item as spam.
  

  Mathieu Ravaux February 27th, 2011 @ 01:34 AM

  Here is a patch that solves this issue.
  I've tested it against Alex's app.

  • accept_header_fix.diff 1.1 KB
• 

  Santiago Pastorino February 27th, 2011 @ 04:01 AM

  • Assigned user set to “Santiago Pastorino”

  hey Methieu we need a test case to apply the patch.
  Thanks.

• You flagged this item as spam.
  

  Mathieu Ravaux February 27th, 2011 @ 05:05 AM

  Hi Santiago, thank you for your quick reply. It's encouraging for a first contribution !

  Here is the testcase:

  • testcase_for_6379_accept_headers.diff 1.2 KB
• 

  Jeff Kreeftmeijer February 27th, 2011 @ 05:25 PM

  Hey Mathieu,

  Nice work on your first patch! The testcase looks good too.

  One thing: could you merge the testcase and the fix into one commit and supply a new patch? :)

• You flagged this item as spam.
  

  Mathieu Ravaux February 28th, 2011 @ 10:50 PM

  Sure, here it is !
  Thanks for reviewing it.

  • 6479_accept_headers_fix_and_testcase.diff 2 KB
• 

  Jeff Kreeftmeijer February 28th, 2011 @ 11:43 PM

  • State changed from “open” to “verified”

  Verified. The patch applies to master and the provided test fails without it. :)

• You flagged this item as spam.
  

  Jason Roth May 7th, 2011 @ 09:22 PM

  Added this issue to github issues:
  https://github.com/rails/rails/issues/439

  -j

• You flagged this item as spam.
  

  Jason Roth May 7th, 2011 @ 09:35 PM

  Ignore my comment above - I posted it to the wrong issue. Sorry -j

• You flagged this item as spam.
  

  Jason Noble May 7th, 2011 @ 10:15 PM

  Moved to Github issue https://github.com/rails/rails/issues/444

• You flagged this item as spam.
  

  Jason Noble May 7th, 2011 @ 11:36 PM

  This has been pushed to master and can be closed.

• You flagged this item as spam.
  

  klkk May 23rd, 2011 @ 02:53 AM

  louisvuittonwarehouse.com

• You flagged this item as spam.
  

  klkk May 23rd, 2011 @ 02:55 AM

  www.louisvuittonwarehouse.com