#648 mail_to :javascript should use decodeURIComponent instead unescape - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#648 ✓committed

mail_to :javascript should use decodeURIComponent instead unescape

Reported by Marc-André Lafortune | July 17th, 2008 @ 10:45 PM | in 2.x

If the 'name' parameter for mail_to contains unicode characters, these will not show properly in the link. Solution involves using to_json before outputing each byte.

Example:

mail_to "xxx@example.com", "Écris-nous", :encode=>:javascript

The link's label will show as "Ãcris-nous".

Solution:

Modify mail_to's code:

-   "document.write('#{content_tag("a", name || email_address, html_options.merge({ "href" => "mailto:"+email_address+extras }))}');".each_byte do |c|
+   "document.write('#{content_tag("a", (name || email_address).to_json[1..-2], html_options.merge({ "href" => "mailto:"+email_address+extras }))}');".each_byte do |c|

Temporary solution for affected users: call to_json yourself, as in:

mail_to "xxx@example.com", "Écris-nous", :encode=>:javascript

Comments and changes to this ticket

You flagged this item as spam.
Marc-André Lafortune July 17th, 2008 @ 10:50 PM
Oups, managed to screw up my very first ticket... The example should read:
```
mail_to "xxx@example.com", "Écris-nous", :encode=>:javascript
```
and the temporary fix:
```
mail_to "xxx@example.com", "Écris-nous".to_json[1..-2], :encode=>:javascript
```
Emilio Tagua July 31st, 2008 @ 09:30 PM
- Title changed from “mail_to :javascript screws up unicode” to “mail_to :javascript should use decodeURIComponent instead unescape”
- Tag set to “actionpack, helper, patch”
Instead of using unescape to decode the generated string, Rails should use decodeURIComponent since it is utf-8 friendly.
I attach the patch and test, i have also tested in browsers that the escaped javascript is the expected.
Emilio Tagua July 31st, 2008 @ 11:45 PM
- no changes were found...
- fix_mail_to_javascript_decoding.diff 5.7 KB
Michael Koziarski August 8th, 2008 @ 02:31 PM
- State changed from “new” to “committed”