#739 Improved named_scope to be used like as with_scope - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#739 ✓wontfix

Improved named_scope to be used like as with_scope

Reported by Genki Takiuchi | August 1st, 2008 @ 10:53 AM | in 2.x

named_scope is really cool feature of the latest Ruby on Rails, but it can't be used with good old with_scope.

So I implemented "with" method to the Scope class so that we can use a scoped block like this:

User.active.with do
  User.count #=> equals to User.active.count
end

Comments and changes to this ticket

You flagged this item as spam.
Genki Takiuchi August 1st, 2008 @ 10:56 AM
Attached the patch.
You flagged this item as spam.
Paweł Kondzior August 1st, 2008 @ 11:02 AM
+1
You flagged this item as spam.
Genki Takiuchi August 1st, 2008 @ 12:36 PM
Removed mail headers from the patch.
- Improved-named_scope-to-be-used-like-as-with_scope.patch 1.3 KB
You flagged this item as spam.
Ryan Bates August 1st, 2008 @ 06:07 PM
I just needed this functionality not too long ago, and the implementation looks nice and simple. However, it looks like tests are missing, could you add some?
Ryan Bates August 1st, 2008 @ 08:42 PM
- no changes were found...
- with_scope_on_named_scope.diff 2.1 KB
You flagged this item as spam.
Ryan Bates August 1st, 2008 @ 08:42 PM
I've been playing around with this a little bit and found out you can completely remove the "with" method on the Scope class and it will still behave properly. This is because when you call "with" it will be delegated to the proxy scope and already apply with_scope.
I propose not using the "with" method at all and just sticking to with_scope. This required a couple minor changes but I've attached a patch which does this.
```
User.active.with_scope do
  User.count #=> equals to User.active.count
end
```
You flagged this item as spam.
Genki Takiuchi August 1st, 2008 @ 10:31 PM
Ryan, I agree with you.
Pratik August 22nd, 2008 @ 04:13 AM
- State changed from “new” to “wontfix”
This is not very with_scope like as with_scope was made a private method after people started abusing it in around_filter, which is against Rails way of doing things.

This should still work, however it should be a protected method.

Might be a good idea to discuss in the mailing list.

Thanks.