Activity (RSS)

Hey Eric,

My bad. I never knew about :having ! Thanks for the enlightenment :)

I still feel the patch is a bit too complex and a better fit for a plugin. Why...

I just noticed there was a needless change of how the elements were being added to the ActiveSupport::OrderedHash.

This updated patch causes keys that were grouped by to be part of a single array. So, for instance, the call:

  c = Account.count(1, :group => [:credit_limit,...

I'm not to fussed about it since I can work around it using the

following helper:

def theme_path(theme, type, filename)

super(theme, type, filename.split('/...

Personally, I'd probably avoid adding a special case with the defence that the added complexity isn't warranted. In my opinion, supplying the path components ...

I'm not sure what I think about that string special case, but at the very least we should document this new behaviour in the release notes.

Can you see any do...

(Second attempt without crazy blockquote formatting)

Unfortunately this patch now forces me to pass path segments as arrays to url helper functions, e.g:

map...

Unfortunately this patch now forces me to pass path segments as arrays to url helper functions, e.g:

map.theme 'themes/:theme/:type/*file',

:contr...

@Ryan_Bates with something like these

change_table :users do |u|

u.add_couter :posts

end

So you don't have to learn more methods name, because we will use ...

@Guillermo, interesting idea, but then how would one add the cache column if the post_id column already exists in comments table?

Since caching usually happen...

add me as a user wishing this patch were applied.

This issue is more than a year old and already extensively discussed at http://dev.rubyonrails.org/ticke....

Basically: when you have a model that has an asso...

I just noticed, it looks like ActiveRecord already has support for :having.

http://github.com/rails/rails/se...

Is this not what you need?

So you're mostly looking for someone to add :having to find?

I found that the way the results were returned (in nested arrays) for the keys that were grouped ...

I think it could be cleaner something like these

t.references :post, :couter=> true

like we already do with for example null or polymorphic

+1 for adding t.counter_cache.

About the loop: if there are millions of rows to be updated then the proposed code is too slow. The counter cache column can be...

Nice. Would it fit to have a "t.counter_cache" method for use in create_table and change_table as well?

This method makes it straightforward to add new columns to work with :counter_cache on ActiveRecord models. Apart from adding the column (default 0), it will u...

FIxed in http://github.com/rails/rails/co...

adding something like:

config.gem "json", :version => ['>= 1.1.2', '< 1.1.3']

in environment.rb fails with: Illformed requirement [">= 1.1.2, < 1.1.3"]

pat...

Can you please provide with more informations to reproduce this ?

Thanks.

I don't like the way the patch does UrlWriter.set_default_url_options_from_request(request). We've been trying to remove such changes which requires a mutex ar...

That's a pretty cool idea. It's similar to ticket #57.

I'm wondering if the :include option might be a good spot for this. Currently it's just used to manage ...

My motivation for this was being able to assign city_id in a mass assignment from a form post, and therefore avoid having to explicitly handle City objects in ...

Not a big fan of this change. If you want the association to change, you should just assign the value using torchbox.city=. And this wouldn't work when you ass...

I already send a message to rails-core on 2008-05-03, even before writing the patch. Koz advised me to write a patch and so I did.

Regarding ActiveModel: Yes,...

Removing "patch" keyword.

Also, I think it's worth noting that very soon we'll be moving validation stuff to ActiveModel, which already has some API changes. ...

Removing "patch" tag.

Resolved in http://github.com/rails/rails/co...

Hey Ryan, looks good but the patch doesn't apply cleanly to latest master. Could you update?

Fixed in http://github.com/rails/rails/co...

(from [089251581137b041828a7e6dcbf75ecbef55b4a3]) Ensure add_column gives valid error for sqlite. [Gunnar Wolf, Pratik] [#197 state:resolved]

SQLite#add_colum...

Adam, we don't have a strict set of rules for tests. If you think it's worth creating a new file for tests, go for it. If you think they're a better fit for so...

Hi again,

Firstly, sorry that I took this long to get back to this ticket, I needed to work on a different project for the past week or so.

Secondly, I've ma...

My change_table doc cleanup in docrails got merged in commit 46f30f90 so this ticket can be marked as resolved.

(from [1b0128c5413ace12dee45e9db328cff866a5bb06]) Don't rely on association proxying object_id. [#225 state:resolved]

http://github.com/rails/rails/co...

Shouldn't you be using has_many :through if you want your join table to be more than just a join table (PS: a word document? Srsly? :-) )

We have support for first/last methods on a model class:

Project.first
Project.last(:order => 'name')

Wouldn't it be nice if this worked on association pro...