Activity (RSS)

(from [5a3fd46d42f05a241b3178af60d38fe5e0cebee6]) Fixing test for named_scope through a has_many :through

The test that checks if a has_many :through associat...

How'd it fail? It seems like an array of posts should never equal a scoped array of comments.

The new rescue_from declarative handlers run in every mode. Since they're usually pimped as a replacement for rescue_action_in_public, I think they should act...

Maybe we could stick with continents, i.e europe_zones, asia_zones, australian_zones, african_zones, south_american_zones, north_american_zones (because there'...

Hi Geoff,

ad 1.) I agree that a Pacific time zone group is probably nothing that will be used very much. I do see much uses for european_zones or asian_zones....

1. If we're to add more convenience methods for grouping time zones, we need to justify each one we add: it should address a common, real-world application nee...

Hello Star Trader,

thank you for the review and valuable input. I do agree that further discussion as to which time zones shall be grouped together is necessa...

When using STI, if a subclass specifies that an attribute is to be serialized, and that attribute was not specified as serialized in the base class, serializat...

Actually, it might not just be a case of the chunk being too big, but that the execute method expects a single sql statement, which makes this a bit more criti...

Looks good, i'm inclined to apply the patch.

Can you guys add me to the rails project?

Added fragment_exist? method.

This is most useful when using file_store cause You reduce the IO operations. And it's better then doing:

read_fragment(path).n...

I don't like the error message itself. I'd personally go with Jeremy's suggestion of showing the object_ids of the two differing classes, with a note in the h...

Hi Joshua,

thank you for the advice. It is the same I had in mind. Together with this comment, I upload an updated patch the pre-computes a US_ZONES constant,...

(from [fc02eabf296d6edb74a95174c7322293a54c9492]) Precompute TimeZone.us_zones [#199 state:resolved]

Signed-off-by: Joshua Peek

http://github.com/rails/rail...

I'd compute on load them right under "ZONES" and put them in a frozen constant "US_ZONES".

While regular expressions are by far the fastest way to search for patterns, they nevertheless are slow compared to using pre-computed values.

I really do lik...

It's probably also worth exploring, is the current method of matching against a regex really all that slow? Maybe a quick benchmark would help justify your eff...

There's already a ticket for this:

http://rails.lighthouseapp.com/p...

Whilst I support the addition of the Time#us_zone functionality, it should be expanded to include other areas, possibly; #euro_zone #asia_zone etc

(from [b28b54cab090bed8f099ef375b419a8f92390dd4]) Make sure needed table joins are included :select option. [#110 state:resolved]

Signed-off-by: Pratik Naik

...

Ah I was looking at prototype_helper_test.rb. The thing is there is currently no test to check whether remote_function DOES add the token for non-GET requests ...

Ok, how about a patch to check for Windows and add the --noreadline option only in that case?

Then command history won't work. This sounds like a problem with your readline install, not the console.

I've spent a few hours today trying to move our rails app to 2.1RC1.

Our company has a significant number of migrations most of which were done using the enha...

I agree with the stated purpose of the ticket, but I'm dubious of the patch. The regular expressions given in the convince methods seem to return more results...

+1

This is a needed clarification of an otherwise nonsense error message. It installs properly and works as advertised. I found no bugs or performance issue...

I'm not sure why it's just showing the class name rather than something like "expected User (), got User (#343e4>)." It'd be trivial to add a call to #inspect...

• script/console is not usable under Windows with german keyboard. It's not even possible to write simple special characters like [].
• Rails console on Netbeans ...

Maybe, I should of clarified what db. I tested on sqlite 3.4 and mysql 5.0.51a.

Briefly checked it out, looks good. However, its going be post-2.1, sorry.

In the meantime, check out http://rails.lighthouseapp.com/p..., and try to reformat...

The us_zones convenience method in TimeZone generates the list of TimeZone objects in the U.S. every time it is called. This is inefficient, especially in appl...

(from [8d37bd08eeac6d0e94f76ac6640e288bf64595b2]) Protect #filter_parameters created by filter_parameter_logging [José Valim] [#196 state:resolved]

http://git...

If you use git format patch, I can get your name and email from it so you show up as the patch author.

Second patch