Activity (RSS)

[PATCH] These patch add: ActiveRecord::Base.each ( User.each {|u| u.name} ) ActiveRecord::Base.map ActiveRecord::Base.collect

But with the diference with User.a...

(from [2183c220ada046993274ccdc6f1f86e9e8a3a5c6]) Make sure clone_structure can load the results of dump_schema_information

SchemaStatements#dump_schema_infor...

It makes a difference because SchemaStatements#dump_schema_information is inconsistent with db:clone_structure in databases.rake, and will create sql that db:c...

Could you reattach with git-format-patch output so we get the authorship etc correct. Also, in the commit message could you mention why this seemingly trivial...

I have the same problem and independently came up with the same patch. +1, please commit.

Unless config.gem … :lib explicitly specified and gem is rails plugin (i.e. have rails/init.rb) GemDependency should leave requires to plugin initializer.

Pat...

The composed_of macro assumes that the value object can be instantiated with new. But for some aggregate classes, new is not the appropriate constructor and in...

Do you have a failing test for that ? Feel free to catch me in #rails-contrib irc channel.

Thanks

(from [150717344aa5c6d8f46fc67de39d6947553ac286]) auto_link helper fails to recognize links separated by space. [#72 state:resolved]

Signed-off-by: Pratik Nai...

Weird: my patch file is not showing up on this issue, and my first comment pointing to my commit on my forked Rails repo is marked as spam.

Let's try again: C...

Here's a patch in case that is easier than doing a pull. Thanks.

If an app indicates four gem dependencies, and none are installed, doing a rake gems:install will install the first gem and exit. Thus one has to run the task ...

The method construct_calculation_sql in calculations.rb constructs invalid SQL when connection.supports_count_distinct? is false, eg for sqlite:

Comment.count...

Closed at Tarmo's request.

The error you're seeing should only exist in ruby-pg and not the postgres gem. The error is only compiled into ruby-pg if it determines your postgresql version...

I'm running PostgreSQL 8.2.6 via MacPorts on Leopard.

Gem: postgres (0.7.9.2008.01.09)

Just upgraded to edge Rails and started to see this. It looks like the connection responds to server_version but libpq doesn't on my machine. Saw a few mention...

Searching the code I had more results with ENV['RAILS_ENV'], so I've used that one. =)

Is there a reason you're using ENV['RAILS_ENV'] and not Rails.environment?

Oh, if :environment is not sent, like:

config.gem "hpricot", :version => '0.6', :source => "http://code.whytheluckystiff.net"

We have the default behaviour, ...

This way we can specify which gems will be loaded in each environment. This is useful since we don't want ZenTest or ruby-debug running in production.

Usage:

...

Ok, patch done in the right away!

Would be nice if someone adds to the tutorial http://rails.lighthouseapp.com/p..., that you have to do a commit to the worki...

If you look at the generated diff files, you'll see things like :

diff --git a/activesupport/lib/active_support/cache.rb b/activesupport/lib/active_support/ca...

1. I think that it's a problem with cygwin (yep, I'm using Windows =/)

2. What do You mean with changing permission of files?

Few things.

1. Could you please use git-format-patch ? It should be possible to get help in #git, #github or #rails-contrib if you're having troubles with tha...

Since I had gone to the trouble of writing a failing test before I found Jeremy's patch on Edge, I figured it would be a good idea to add the test anyway.

Att...

Jeremy fixed this already in Edge (Commit eb837b52e34c1f7f0c71d704ffdb3e4eb4b582e2).

(from [345f030c5b6c0a28ddde56c80a1112b00d345c79]) Ensure routing generator works with non-string keys. [#172 state:resolved]

Make sure that (with recent corre...

Committing using .to_param instead of .to_s and minor modification to the test.

Thanks.

OK, I got the point: This functionality is better implemented in an i18n plugin. No worries.

But: You should really think about what kind of impression it mak...

Here's an example of how to float a custom grouping of zones to the top of time_zone_select:

# config/initializers/time_zones.rb:
MY_ZONES = [ TimeZone['Alas...

I'm advocating that we only add additional TimeZone convenience methods to core if we can prove there's a common need for them in real-world applications.

De...

To be clear, I'm not advocating leaving out one world region. I'm advocating that we only add additional TimeZone convenience methods to core if we can prove t...

(from [77f873acf2f1fb4533dfca6b26b965a115ebbc54]) dbconsole should not require a username for postgresql. [#207 state:resolved]

Signed-off-by: Pratik Naik

h...

If you don't have a username set in your database.yml when using the postgresql adapter, you can't launch dbconsole. Patch attached fixes that.

It's very common to use rescue_from along with AR#save! method to render 'edit' or 'new' on validation failures, irrespective of dev/prod mode. And many simila...

(from [3baf810482303126c75daa7915e200030d1755e0]) Add rdoc task to activemodel. [#156 state:resolved]

Signed-off-by: Pratik Naik

http://github.com/rails/rai...

Removed main Rakefile hack.

Hi

In this commit http://github.com/rails/rails/co..., you (Pratik), insert a serie of shortcuts for RAILS_* constants.

Well, I like this change, but I think...