Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Monday, May 19 2008
225 Ruby 1.9 Compat: Redefining object_id and Rational.new! was created
  • Nate Wiger
    Nate Wiger created the ticket at 8:33 PM

    This patch fixes two Ruby 1.9 compatibility issues:

    • Use of Rational.new! in the active_support tzinfo classes, which is a private method in Ruby 1.9
    • Inadver...
195 Convenience methods for time zones outside the U.S. was updated
  • Geoff Buesing
    Geoff Buesing commented at 7:48 PM

    I like Josh's suggestion -- a TimeZone ~= method could match based on either the #name or the TZInfo identifier in the MAPPING hash.

    The time_zone_select prio...

  • josh
    josh commented at 5:47 PM

    Nevermind. Didnt see it was matching the name attr. Geoff, I'd consider adding TimeZone~= And just keep the US zones.

  • josh
    josh commented at 12:43 PM
    TimeZone.zones_by_regex(/../) # 30 char
    TimeZone::ZONES ~= /../ # 24 char
    

    Sorry, but I think zones_by_regex does not help really help.

  • Adam S
    Adam S commented at 8:16 AM

    Can't help chipping in here:

    It's irrelevant whether the us_zones choice came from a non-US resident. Initially it seemed like a nice addition, but rejection ...

Workaround missing Test::Unit::TestCa... was committed by Repository at 7:16 PM
224 Ruby 1.8.6 required for Rails 2.1? was updated
  • Repository
    • State changed from new to resolved
    by Repository at 7:16 PM

    (from [2b6bec5cdd84c4ba65cbe99ae48697d977ae9491]) Workaround missing Test::Unit::TestCase::PASSTHROUGH_EXCEPTIONS in Ruby < 1.8.6. [#224 state:resolved]

    http...

  • Pete Deffendol
    Pete Deffendol created the ticket at 6:44 PM

    Apparently Rails now requires Ruby 1.8.6, since the ActiveSupport:TestCase changes were made in January? I'm running the 2.1 release candidate, and get the fo...

197 SQLiteAdapter fails with a dark message when creating columns when inside a t... was updated
  • Gunnar Wolf
    Gunnar Wolf commented at 5:33 PM

    Here it is - I'm doing the test for the second case I mentioned (raising a StatementInvalid when adding a column inside a transaction).

    Stylistically it might...

  • Pratik
    • State changed from new to incomplete
    • Assigned user set to Pratik
    by Pratik at 11:12 AM

    Can you please add a test case verifying expected exception is raised for sqlite adapter ?

    Thanks.

223 named_scope that composes other named_scopes was created
  • Henrik Nyh
    Henrik Nyh created the ticket at 5:28 PM

    It would be very useful if you could do e.g.

    named_scope :published, ...
    named_scope :japanese, ...
    named_scope :popular, :conditions => ..., :compose => :p...
222 named_scope :order on association with :order is unintuitive was created
  • Henrik Nyh
    Henrik Nyh created the ticket at 4:55 PM

    If I have

    class Foo < ActiveRecord::Base
      has_many :bars, :order => 'one'
    end
    
    class Bar < ActiveRecord::Base
      named_scope :by_two, :order => 'two'
      ...
198 caches_action with :layout option was updated
  • José Valim
    José Valim commented at 2:00 PM

    Patch using format-patch. =)

Test for assert_response for failure ... was committed by Repository at 11:22 AM
141 assert_response assumes a rendered template was updated
  • Repository
    • State changed from open to resolved
    by Repository at 11:22 AM

    (from [e6f5079a48094eeba3dab9dca52b16b58ddc3634]) Test for assert_response for failure response without an exception. [#141 state:resolved]

    Signed-off-by: Pra...

124 Fixture named accessors do not work when the fixture name is not the table name was updated
  • Pratik
    • State changed from new to incomplete
    • Assigned user set to Pratik
    by Pratik at 11:09 AM

    Can you please rewrite the patch to use an existing table instead of creating a new table ?

    Rest looks fine.

    Thanks!

Add fragment_exist? and exist? method... was committed by Repository at 10:47 AM
203 Added fragment_exist? method was updated
  • Repository
    • State changed from new to resolved
    by Repository at 10:47 AM

    (from [99860b72aebe0348f41e82d4710343498d89a84b]) Add fragment_exist? and exist? methods to cache stores. [#203 state:resolved]

    Signed-off-by: Pratik Naik

    h...

221 Routing error with ActionView::Helpers::ActiveRecordHelper#form was updated
  • Armin Joellenbeck
    Armin Joellenbeck commented at 10:46 AM

    Sorry,

    for the next ticket I schould read the help for formatting the text.

    Armin

  • Armin Joellenbeck
    Armin Joellenbeck created the ticket at 10:24 AM

    When I use the method above, I get the following error:

    Showing projects/show.html.builder where line #9 raised:

    No route matches {:action=>"/proj...

Ensure observe_field encodes value pa... was committed by Repository at 10:32 AM
216 observe_field should escape the parameter it is submitting was updated
  • Repository
    • State changed from new to resolved
    by Repository at 10:32 AM

    (from [17d1319c480e58e28641b243da50ae5e5eab89dc]) Ensure observe_field encodes value parameter. [#216 state:resolved]

    Signed-off-by: Pratik Naik

    http://gith...

220 habtm: collection.build doesn't build join associations (unlike collection.cr... was updated
  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 6:09 AM

    I am just all kinds of wrong tonight. You can, of course, call #build on a new record just fine. (it's #create that you can't call on a new record)

  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 5:27 AM

    Ah... the two records want to validate each other. That results in a nice runaway loop.

    Code could be added to the validation to prevent looping, but I'm wond...

  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 4:47 AM

    A quick look through the source seems to suggest that simply adding the existing record to the association collection of the new record would create the desire...

  • bentlegen
    bentlegen commented at 4:20 AM

    Thanks for the explanation Chris - I understand now.

    Still, it seems odd to me that these two code examples behave differently:

    project = user.project.build
    ...
  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 4:10 AM

    From what I can tell, this isn't a bug:

    When you #build off an association, the join table is updated when you call #save on the object from which you called ...

3 earlier changes…
  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 3:51 AM

    I misread the ticket, and I was wrong about the tests covering this case.

  • bentlegen
    bentlegen commented at 3:51 AM

    activerecord (2.0.2)

    The problem is that, even if I call #save after #build, the associations aren't saved in the join table. The AR documentation suggests th...

  • Christopher Swasey (endash)
    Christopher Swasey (endash) commented at 3:38 AM

    Could you clarify what version of rails you are using? Edge rails includes tests which test this functionality, and they all pass.

    Also, #build doesn't save t...

Sunday, May 18 2008
220 habtm: collection.build doesn't build join associations (unlike collection.cr... was created
  • bentlegen
    bentlegen created the ticket at 8:51 PM

    I have a habtm relationship between two models. When I try to #build one object through the collection helper of a record that persists in the database, it doe...

Adding documentation for time zone fe... was committed by Repository at 8:14 PM
215 ActiveRecord::Base.each instance method was updated
Hash.from_xml: datetime xml types ove... was committed by Repository at 5:48 PM
TimeWithZone #+ and #- : ensure overf... was committed by Repository at 5:15 PM
InstanceTag#default_time_from_options... was committed by Repository at 4:59 PM
Time#to_json: don't convert to utc be... was committed by Repository at 4:48 PM
time_zone_select docs: explain priori... was committed by Repository at 4:26 PM
219 script/generate model creates wrong unit test file was updated
209 Added :environment options to config.gem was updated
  • DHH
    • State changed from open to invalid
    by DHH at 11:38 AM

    You can just do this in config/environments/test.rb:

    config.gem "ZenTest"

    Then it's only loaded in the test environment.

195 Convenience methods for time zones outside the U.S. was updated
144 [PATCH] Bug in Rails Route Globbing was updated
  • Michael Koziarski
    Michael Koziarski commented at 7:09 AM

    Ah yes, I remember that, sadly it doesn't look like anything came of it. Perhaps we can put some more effort, post 2.1, to seperate the mapping from the recog...

183 strange link_to behavior on links to controllers in modules was updated
  • Amol Hatwar (rubygem)
    Amol Hatwar (rubygem) commented at 5:42 AM

    If someone can confirm that this indeed is a *bug*, maybe I can work towards a patch that fixes it...

Saturday, May 17 2008
214 GemDependency should not require default @lib if gem is rails plugin was updated
  • Pratik
    • Assigned user set to Rick
    by Pratik at 11:24 PM
213 Rails::GemPlugin should expose its load_paths to add them to Dependencies was updated
  • Pratik
    • Assigned user set to Rick
    by Pratik at 11:24 PM
217 response#success? isn't true for response "201 created" was created
  • Esad Hajdarevic
    Esad Hajdarevic created the ticket at 11:10 PM

    In module TestResponseBehavior, in actionpack/lib/action_controller/test_process.rb, whose methods are included in CgiResponse during integration testing, succ...

215 ActiveRecord::Base.each instance method was updated
  • Guillermo Álvarez
    Guillermo Álvarez commented at 8:24 PM

    My situation is these:

    desc 'Copy Posts from the phpbB3 table to the new forum'

    task :copy_posts => :environment do

    BbTopic.find(:all).each do |bb|

    f = Pos...

  • Guillermo Álvarez
    Guillermo Álvarez commented at 8:15 PM

    ActiveRecord::Base.each

    ActiveRecord::Base.map

    ActiveRecord::Base.collect

    With migrations between two or more databases, is common to do something like

    Use...

195 Convenience methods for time zones outside the U.S. was updated
  • Geoff Buesing
    Geoff Buesing commented at 8:17 PM

    The us_zones method is potentially helpful to devs all over the world, not just US-based devs.

    Proof in point: the us_zones method was first added to the fram...

216 observe_field should escape the parameter it is submitting was created
  • Frederick Cheung
    Frederick Cheung created the ticket at 7:14 PM

    The base forms of observe_field wind up with us generating javascript like

      parameters: 'q=' + value
    

    value here is just the form elements value, which hasn...