#1272 ruby19 incompatibility: ActiveResource::Connection#http, use_ssl? - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1272 ✓committed

ruby19 incompatibility: ActiveResource::Connection#http, use_ssl?

Reported by dvdplm | October 26th, 2008 @ 01:25 PM | in 2.3.4

(I have no idea if this is the way you people want your bugs reported. The instructions are very very confusing; please forgive me if I'm doing this the wring way.)

Description: ActiveResource::Connection#http uses Net::HTTP#use_ssl -- an alias to use_ssl? -- which doesn't exist anymore in Ruby 1.9.

Fix: change to use use_ssl? instead, like so: activeresource/lib/active_resource/connection.rb, line 192

http.verify_mode = OpenSSL::SSL::VERIFY_NONE if http.use_ssl?

Comments and changes to this ticket

Pratik March 7th, 2009 @ 08:30 PM
Hey dvdplm,

You might wanna have a glance at http://guides.rails.info/contrib... for the contribution guide. And please do let us know if that's not clear enough, we're aiming to make it as straight forward as possible.
You flagged this item as spam.
Brendan Schwartz March 25th, 2009 @ 07:23 PM
- Tag set to “activeresource, active_resource, patch, ruby1.9, ruby19, ssl”
dvdplm nailed it. Patch attached. Works for me in Ruby 1.9.1 and 1.8.x.
- active_resource_ruby19_ssl_fix.diff 1 KB
You flagged this item as spam.
dvdplm March 25th, 2009 @ 08:56 PM
@brendan: thanks a lot! :)
You flagged this item as spam.
Samsonov Ivan May 13th, 2009 @ 01:58 PM
I've the same problem.
You flagged this item as spam.
Scott Barr May 23rd, 2009 @ 02:58 AM
Patch works for me with Ruby 1.9.1 and 1.8.7
You flagged this item as spam.
Niels Ganser July 16th, 2009 @ 11:49 AM
+1

Patch applies cleanly on latest checkout from 2-3-stable and works as advertised.
Michael Koziarski July 19th, 2009 @ 08:10 AM
- Milestone changed from “2.x” to “2.3.4”
You flagged this item as spam.
Dr Nic August 7th, 2009 @ 07:12 PM
I pulled down edge rails and it doesn't seem this old patch is applied yet I think. Has this ticket been applied to master? or is it in a branch somewhere?

This is a known bug that's open since October 2008 and fixed in March 2009.
Pratik August 7th, 2009 @ 07:29 PM
- Assigned user set to “Jeremy Kemper”
Repository August 7th, 2009 @ 08:28 PM
- State changed from “new” to “committed”
(from [e1d27eedceea46531d11c03c1e1e61ba15a5fdf2]) Ruby 1.9 compat: fix for SSL in Active Resource

[#1272 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/e1d27eedceea46531d11c03c1e1e61...
Repository August 7th, 2009 @ 08:28 PM
(from [201387496e057d4853520be9837b2a807c66cc48]) Ruby 1.9 compat: fix for SSL in Active Resource

[#1272 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/201387496e057d4853520be9837b2a...
You flagged this item as spam.
Ron Newman January 4th, 2010 @ 07:12 PM
Is this the same bug as #2971 ?