Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  Paweł Kondzior November 15th, 2008 @ 09:44 PM

  It's based on this http://dev.rubyonrails.org/ticke...

• You flagged this item as spam.
  

  Paweł Kondzior November 16th, 2008 @ 12:21 PM

  • Tag set to “activerecord, patch, scope”

  I've added more tests for scopes

  • active_record_default_scope_with_tests.diff 3.2 KB

• You flagged this item as spam.
  

  Paweł Kondzior November 16th, 2008 @ 02:51 PM

  default_scope with named_scope syntaxt.

  class Client < ActiveRecord::Base default_scope :order => 'name DESC' end

• 

  Paweł Kondzior November 16th, 2008 @ 02:52 PM

  • no changes were found...

  • active_record_default_scope_with_tests_named_scope_syntaxt.diff 3.3 KB
• 

  Repository November 16th, 2008 @ 03:01 PM

  • State changed from “new” to “committed”

  (from [ff594b2bc94ff2a942fe6ca05672387722dee686]) Added default_scope to Base [#1381 state:committed] (Paweł Kondzior) http://github.com/rails/rails/co...

• 

  DHH November 16th, 2008 @ 03:37 PM

  • State changed from “committed” to “open”

  This actually won't work with threads because:

      def scoped_methods #:nodoc:
        Thread.current[:"#{self}_scoped_methods"] ||= []
      end
  
  

  So we need to promote default_scope to a class var and change the ||= [] to ||= default_scope.dup initialize default_scope to [].

• 

  Repository November 16th, 2008 @ 03:37 PM

  • State changed from “open” to “committed”

  (from [ca23287b448c2e007a5c93e43e762a10e0007b7a]) Revert "Added default_scope to Base [#1381 state:committed] (Paweł Kondzior)" -- won't gel with threads.

  This reverts commit ff594b2bc94ff2a942fe6ca05672387722dee686. http://github.com/rails/rails/co...

• You flagged this item as spam.
  

  Paweł Kondzior November 16th, 2008 @ 04:42 PM

  Thread safe version.

  • default_scope_thread_safe.diff 4 KB

• You flagged this item as spam.
  

  Paweł Kondzior November 16th, 2008 @ 05:05 PM

  cattr_accessor wont work, it will fail all because it will define default_scope for ActiveRecord::Base not for Model that inherts from it. So class var isn't solution here :(

• 

  Repository November 16th, 2008 @ 06:08 PM

  (from [2530d0eea8eaecd2c61f99225f050ff47973e9a0]) Added default_scope to Base [#1381 state:committed] (Paweł Kondzior) http://github.com/rails/rails/co...

• You flagged this item as spam.
  

  Tom Stuart November 17th, 2008 @ 08:19 PM

  This doesn't work right in combination with other named scopes because :create is initialised to nil if :conditions isn't specified, causing a failure when with_scope tries to call merge on it. The attached patch changes the behaviour to initialise :create to {}, which fixes the problem. Test included.

  • 0001-Fix-default_scope-to-work-in-combination-with-named.patch 4 KB
• 

  DHH November 17th, 2008 @ 09:08 PM

  Committed the fix, Tom. Thanks.

• You flagged this item as spam.
  

  Daniel Luz December 1st, 2008 @ 05:00 AM

  The documentation is slightly out of date. This is a quick fix.

  • 0001-Update-documentation-for-default_scope.patch 1.2 KB

• You flagged this item as spam.
  

  Michał Szajbe January 22nd, 2009 @ 01:38 PM

  When default_scope's :conditions is something like { :field => ['val1', 'val2'] } then new record's field is initialized to "['val1', 'val2']" which is not desired behaviour I think. I am not sure how it should be initialized then, though.