assert_redirected_to is too strict

+1

+1 !

I don't have a patch, but have a slew of tests that are affected by the new behavior of the assert_redirected_to. It is more than just being too strict, it appears to not match routes correctly from the routes.rb as well. I can post examples if it will help? I'd love to help if I can!

Just trying to help:

routes.rb:

map.connect '/:address', :controller => 'page', :action => 'show'

Unit Test:

assert_generates  "/page-name", {:controller => "page", :action => "show", :address => 'page-name'}
assert_recognizes "/page-name", {:controller => 'page', :action => 'show', :address => 'page-name'}

This will not work in Rails 2.2.2

Okay, disregard my last post. This is a better way to capture the issue:

routes.rb

 map.connect '/:address', :controller => 'page', :action => 'show'

controller

 redirect_to('/page-name')

test

assert_redirected_to(ActionController::Routing::Routes.recognize_path(@response.redirected_to), @response.redirected_to)

That test should always pass, since the recognize_path method will return the params hash of the redirected_to url. BUT

Test::Unit::AssertionFailedError Exception: Expected response to be a redirect to <http://www.gracechurch.org/admin/display/show?address=page-name> but was a redirect to <http://www.gracechurch.org/page-name>.

So, the assert_redirected_to is not assembling the correct route for the hash options provided in the first parameter.

i have experienced a bunch of new failing tests also upon upgrading to 2.2.2 but it would appear that the issue isn't exactly a bug, but rather intentionally reduced functionality while increasing simplicity of the code for both the assert and redirect_to itself.

i think this is the breaking commit: http://github.com/rails/rails/co...

and this seems to be related: http://rails.lighthouseapp.com/p...

my particular case is

controller:

redirect_to :controller => :patients, :action => :show, :id => @patient 

test:

assert_redirected_to :controller => :patients, :action => :show

works, but if i change controller to

redirect_to patient_path(@patient)

i get

response to be a redirect to <http://test.host/patients/996333082> but was a redirect to <http://test.host/patients/979761894>

i didn't specify an ID in my assert at all - so something is wrong. this asserted fine in 2.1.

the workaround for me is to use the patient_path approach in the controller and use

assert_redirected_to assigns(:patient)

in the test, as suggested by the maintainer in the second link posted above. which does work, and is actually cleaner in a way .. fine for my small site, but maybe this is less fine for others

Any updates to this ticket? This is still an issue on Rails master?